Conversation
facebook-github-bot
added
the
CLA Signed
|
Once this change is released I can wrap up these changes react-native-community/cli#1068 |
Base commit: cf02bd9 |
kelset
left a comment
kelset
left a comment
There was a problem hiding this comment.
First off, thanks for working on this 👏
It will make everyone's life easier and better 👍
I've left a few comments but nothing blocking 👍
| ./gradlew :RNTester:android:app:installJscDebug || error "Couldn't build RNTester Android" | ||
|
|
||
| info "Deleting previously installed Android RNTester app" | ||
| adb uninstall com.facebook.react.uiapp |
| info "" | ||
| read -n 1 | ||
| adb shell am start -n com.facebook.react.uiapp/.RNTesterActivity | ||
| # Prepare |
There was a problem hiding this comment.
I would probably change a bit this section to 'clean up the house' more. For ex. I'd extract (similar to what happens to kill_packagers) all the cleanup part to its own method and in it, something along the lines of:
clean_folders() {
rm -rf android
rm react-native-*.tgz
rm -rf /tmp/RNTestProject
rm -rf node_modules
}
and call it after info "Preparing version $PACKAGE_VERSION"
What do you think?
PS: maybe we could even add some more scripts to that like
rm -rf ~/Library/Developer/Xcode/DerivedData/*
| # iOS | ||
| pushd RNTester | ||
| { | ||
| info "Press any key to open the workspace in Xcode, then build and test manually." |
There was a problem hiding this comment.
not sure if it should live here or not, but I was wondering if it was useful to run rm -rf ios/build...
| info "" | ||
| read -n 1 | ||
| success "Installing CocoaPods dependencies" | ||
| rm -rf Pods && pod install |
There was a problem hiding this comment.
...and pod cache clean --all here.
Too much?
There was a problem hiding this comment.
Hmm, yeah that seems a bit much. What is your experience with this?
There was a problem hiding this comment.
tbh just that I am a bad person and I do tabula rasa on my projects when I need to ensure full clean 😂 and you know way better than me how Pods work so I'm fully ok with not including this command 👍
| cd "$repo_root" | ||
| # Test new app from template | ||
| { | ||
| npm pack |
There was a problem hiding this comment.
| npm pack | |
| yarn pack |
(or is it a npm specific command?)
There was a problem hiding this comment.
Not really, but it also doesn’t do anything with version resolving, so I’m less worried about it. I can take a look, though, and make the whole script uniform 👍
| popd | ||
| } | ||
|
|
||
| info "Next steps:" |
There was a problem hiding this comment.
tbh I think that these last 2 lines could be even be removed, I don't think they provide any actual value. Or maybe we could change the link to point to https://github.com/react-native-community/releases/blob/master/README.md or even https://github.com/react-native-community/releases/blob/master/docs/release-process.md?
|
closing this as it's stale + we moved to a new script #34513 |
6 participants
Summary
Cleans up and improves the manual e2e test script:
yarninstead ofnpmto install dependencies that have previously been recorded inyarn.lockRNTestProjectRNTesterappRNTestProjectappRNTesterautomatically in background instead of requiring manual interventionChangelog
[Internal] [Fixed] - Fix and smoothen usage of
test-manual-e2e.shscriptTest Plan
Ran it manually many times.