Fix Switch ref forwarding #31629
Fix Switch ref forwarding #31629
Conversation
facebook-github-bot
added
CLA Signed
Base commit: 8ca18f0 |
|
This also breaks the integration tests in react-native-windows. |
| const nativeSwitchRef = React.useRef<?React.ElementRef< | ||
| typeof SwitchNativeComponent | typeof AndroidSwitchNativeComponent, | ||
| >>(null); | ||
| const _setNativeRef = setAndForwardRef({ |
There was a problem hiding this comment.
Can this just be useImperativeHandle(nativeSwitchRef)?
There was a problem hiding this comment.
I don't think this would work since nativeSwitchRef is just the internal ref used by this component. We need to set the ref to both nativeSwitchRef and forwarded ref, which is what setAndForwardRef was made for if I understand correctly.
There was a problem hiding this comment.
Whoops, my api usage is wrong.
I think this
useImperativeHandle(forwardedRef, () => nativeSwitchRef, [nativeSwitchRef])
setAndForwardRef is needed if the component attaches a bunch of other methods to the ref too. But that doesn't seem to be the case here
There was a problem hiding this comment.
Interesting, haven't seen this pattern before, but yea it would work. Seems like it is used here also
|
@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@lunaleaps merged this pull request in 1538fa4. |
Summary: Since moving Switch to a function component it is no longer possible to get the native switch ref. This adds forwardRef so it is possible again. ## Changelog [General] [Fixed] - Fix Switch ref forwarding Pull Request resolved: facebook#31629 Test Plan: Tested the change in an app using react-native-gesture-handler, which tries to set a ref on Switch. Also made sure flow still passes. Reviewed By: TheSavior Differential Revision: D28839605 Pulled By: lunaleaps fbshipit-source-id: 1fee86145caeabb60c0010bb9062dddca419f7ca
5 participants
Summary
Since moving Switch to a function component it is no longer possible to get the native switch ref. This adds forwardRef so it is possible again.
Changelog
[General] [Fixed] - Fix Switch ref forwarding
Test Plan
Tested the change in an app using react-native-gesture-handler, which tries to set a ref on Switch. Also made sure flow still passes.