OSS CI: Store bundle size info for release branch as well #32418

fkgozali · 2021-10-16T23:08:41Z

Summary:
This commit does 2 things:

Process and store stats for *-stable branches, in addition to main
Print out the new stats to stdout, so that CI jobs can display them for verification purpose

This also means a new field branch is used for the Firestore data.

Changelog: [Internal]

Differential Revision: D31717251

facebook-github-bot · 2021-10-16T23:09:03Z

This pull request was exported from Phabricator. Differential Revision: D31717251

analysis-bot

Code analysis results:

eslint found some issues. Run yarn lint --fix to automatically fix problems.

analysis-bot · 2021-10-16T23:12:31Z

bots/report-bundle-size.js

-        collection,
-        GITHUB_SHA,
-        validatedStats,
-      );


prettier/prettier: Replace ·await·datastore.getLatestDocument(collection,·GITHUB_REF with ⏎········(await·datastore.getLatestDocument(collection,·GITHUB_REF)

analysis-bot · 2021-10-16T23:12:31Z

bots/report-bundle-size.js

-      }),
-      '',
-      `Base commit: ${document.commit}`,
-    ].join('\n');


prettier/prettier: Replace ·await·datastore.getLatestDocument(collection,·'main' with ⏎······(await·datastore.getLatestDocument(collection,·'main')

pull-bot · 2021-10-16T23:12:36Z

	Messages
📖	📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: `[CATEGORY] [TYPE] - Message`. Details CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖	📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖	📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against ed38289

facebook-github-bot · 2021-10-16T23:16:55Z

This pull request was exported from Phabricator. Differential Revision: D31717251

…2418) Summary: Pull Request resolved: facebook#32418 This commit does 2 things: * Process and store stats for *-stable branches, in addition to main * Print out the new stats to stdout, so that CI jobs can display them for verification purpose This also means a new field `branch` is used for the Firestore data. Changelog: [Internal] Differential Revision: D31717251 fbshipit-source-id: d5a5e03c7937ae5209f3d2d33e1f9cc6631da913

facebook-github-bot · 2021-10-16T23:19:00Z

This pull request was exported from Phabricator. Differential Revision: D31717251

…2418) Summary: Pull Request resolved: facebook#32418 This commit does 2 things: * Process and store stats for *-stable branches, in addition to main * Print out the new stats to stdout, so that CI jobs can display them for verification purpose This also means a new field `branch` is used for the Firestore data. Changelog: [Internal] Differential Revision: D31717251 fbshipit-source-id: 2dc5df543ed6956f65c49600af25a22808871738

pull-bot · 2021-10-16T23:27:59Z

PR build artifact for 748b377 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

analysis-bot · 2021-10-16T23:45:46Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,718,707	+0
android	hermes	armeabi-v7a	7,246,378	+0
android	hermes	x86	8,138,127	+0
android	hermes	x86_64	8,103,429	+0
android	jsc	arm64-v8a	9,637,679	+0
android	jsc	armeabi-v7a	8,552,880	+0
android	jsc	x86	9,651,387	+0
android	jsc	x86_64	10,260,380	+0

Base commit: e1b698c
Branch: main

analysis-bot · 2021-10-16T23:48:27Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: e1b698c
Branch: main

facebook-github-bot · 2021-10-17T07:40:20Z

This pull request was exported from Phabricator. Differential Revision: D31717251

…2418) Summary: Pull Request resolved: facebook#32418 This commit does 2 things: * Process and store stats for *-stable branches, in addition to main * Print out the new stats to stdout, so that CI jobs can display them for verification purpose This also means a new field `branch` is used for the Firestore data. Changelog: [Internal] Differential Revision: D31717251 fbshipit-source-id: 7fb653ef21fcd110318ad306947b9abce7e931c5

pull-bot · 2021-10-17T07:51:01Z

PR build artifact for 9deb97b is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

…2418) Summary: Pull Request resolved: facebook#32418 This commit does 2 things: * Process and store stats for *-stable branches, in addition to main * Print out the new stats to stdout, so that CI jobs can display them for verification purpose This also means a new field `branch` is used for the Firestore data. Changelog: [Internal] Differential Revision: D31717251 fbshipit-source-id: 86dc30c24d00238449546c3987e9e3ed0b081ffe

facebook-github-bot · 2021-10-17T08:14:28Z

This pull request was exported from Phabricator. Differential Revision: D31717251

pull-bot · 2021-10-17T08:23:19Z

PR build artifact for ed38289 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

facebook-github-bot · 2021-10-18T18:06:47Z

This pull request has been merged in 0c07500.

Summary: Pull Request resolved: #32418 This commit does 2 things: * Process and store stats for *-stable branches, in addition to main * Print out the new stats to stdout, so that CI jobs can display them for verification purpose This also means a new field `branch` is used for the Firestore data. Changelog: [Internal] Reviewed By: hramos Differential Revision: D31717251 fbshipit-source-id: 9dbfa8fb8f0243c013dcd822230400d26c09eaa4

fkgozali requested a review from hramos as a code owner October 16, 2021 23:08

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Oct 16, 2021

analysis-bot suggested changes Oct 16, 2021

View reviewed changes

fkgozali force-pushed the export-D31717251 branch from 0626809 to 43e0453 Compare October 16, 2021 23:17

fkgozali force-pushed the export-D31717251 branch from 43e0453 to 748b377 Compare October 16, 2021 23:19

fkgozali force-pushed the export-D31717251 branch from 748b377 to 9deb97b Compare October 17, 2021 07:40

fkgozali force-pushed the export-D31717251 branch from 9deb97b to ed38289 Compare October 17, 2021 08:14

facebook-github-bot closed this in 0c07500 Oct 18, 2021

facebook-github-bot added the Merged This PR has been merged. label Oct 18, 2021

OSS CI: Store bundle size info for release branch as well #32418

OSS CI: Store bundle size info for release branch as well #32418

Uh oh!

Conversation

fkgozali commented Oct 16, 2021

Uh oh!

facebook-github-bot commented Oct 16, 2021

Uh oh!

analysis-bot left a comment

Choose a reason for hiding this comment

Uh oh!

analysis-bot Oct 16, 2021

Choose a reason for hiding this comment

Uh oh!

analysis-bot Oct 16, 2021

Choose a reason for hiding this comment

Uh oh!

pull-bot commented Oct 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Oct 16, 2021

Uh oh!

facebook-github-bot commented Oct 16, 2021

Uh oh!

pull-bot commented Oct 16, 2021

Uh oh!

analysis-bot commented Oct 16, 2021

Uh oh!

analysis-bot commented Oct 16, 2021

Uh oh!

facebook-github-bot commented Oct 17, 2021

Uh oh!

pull-bot commented Oct 17, 2021

Uh oh!

facebook-github-bot commented Oct 17, 2021

Uh oh!

pull-bot commented Oct 17, 2021

Uh oh!

facebook-github-bot commented Oct 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pull-bot commented Oct 16, 2021 •

edited

Loading