Fix Buck failure for KeyError: 'fbandroid_compiler_flags'#32446
Closed
cortinico wants to merge 1 commit intofacebook:mainfrom
Closed
Fix Buck failure for KeyError: 'fbandroid_compiler_flags'#32446cortinico wants to merge 1 commit intofacebook:mainfrom
cortinico wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Attempting to fix the public CI failure for `KeyError: 'fbandroid_compiler_flags'` Changelog: [Internal] [Changed] - Fix Buck failure for KeyError: 'fbandroid_compiler_flags' Differential Revision: D31797803 fbshipit-source-id: db4d187cd351cf0b937eea19cd93cf6af28ef43a
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D31797803 |
|
Base commit: e494e4b |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 24, 2025
…acebook#32446) Summary: ## Summary > [!NOTE] > This only modifies types, so shouldn't have an impact at runtime. Some time ago we moved some type definitions from React to React Native in facebook#26437. This continues making progress on that so values that are created by React Native and passed to the React renderer (in this case public instances) are actually defined in React Native and not in React. This will allow us to modify the definition of some of these types without having to make changes in the React repository (in the short term, we want to refactor PublicInstance from an object to an interface, and then modify that interface to add all the new DOM methods). ## How did you test this change? Manually synced `ReactNativeTypes` on top of facebook#49602 and verified Flow passes. DiffTrain build for [9dd378ff1222335ff133bab2d61001fcc84a1c56](facebook/react@9dd378f) Differential Revision: D70091830
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 24, 2025
…terface (facebook#32446) Summary: ## Summary > [!NOTE] > This only modifies types, so shouldn't have an impact at runtime. Some time ago we moved some type definitions from React to React Native in facebook#26437. This continues making progress on that so values that are created by React Native and passed to the React renderer (in this case public instances) are actually defined in React Native and not in React. This will allow us to modify the definition of some of these types without having to make changes in the React repository (in the short term, we want to refactor PublicInstance from an object to an interface, and then modify that interface to add all the new DOM methods). ## How did you test this change? Manually synced `ReactNativeTypes` on top of facebook#49602 and verified Flow passes. DiffTrain build for [9dd378ff1222335ff133bab2d61001fcc84a1c56](facebook/react@9dd378f) Differential Revision: D70091830
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 24, 2025
…acebook#32446) Summary: ## Summary > [!NOTE] > This only modifies types, so shouldn't have an impact at runtime. Some time ago we moved some type definitions from React to React Native in facebook#26437. This continues making progress on that so values that are created by React Native and passed to the React renderer (in this case public instances) are actually defined in React Native and not in React. This will allow us to modify the definition of some of these types without having to make changes in the React repository (in the short term, we want to refactor PublicInstance from an object to an interface, and then modify that interface to add all the new DOM methods). ## How did you test this change? Manually synced `ReactNativeTypes` on top of facebook#49602 and verified Flow passes. DiffTrain build for [9dd378ff1222335ff133bab2d61001fcc84a1c56](facebook/react@9dd378f) Differential Revision: D70091830
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
…32446) Summary: ## Summary > [!NOTE] > This only modifies types, so shouldn't have an impact at runtime. Some time ago we moved some type definitions from React to React Native in #26437. This continues making progress on that so values that are created by React Native and passed to the React renderer (in this case public instances) are actually defined in React Native and not in React. This will allow us to modify the definition of some of these types without having to make changes in the React repository (in the short term, we want to refactor PublicInstance from an object to an interface, and then modify that interface to add all the new DOM methods). ## How did you test this change? Manually synced `ReactNativeTypes` on top of #49602 and verified Flow passes. DiffTrain build for [9dd378ff1222335ff133bab2d61001fcc84a1c56](facebook/react@9dd378f) Reviewed By: poteto Differential Revision: D70091830 fbshipit-source-id: 2cc49d8ed89e8ee2531dbc4094ef9720fc3040ad
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
…acebook#32446) Summary: ## Summary > [!NOTE] > This only modifies types, so shouldn't have an impact at runtime. Some time ago we moved some type definitions from React to React Native in facebook#26437. This continues making progress on that so values that are created by React Native and passed to the React renderer (in this case public instances) are actually defined in React Native and not in React. This will allow us to modify the definition of some of these types without having to make changes in the React repository (in the short term, we want to refactor PublicInstance from an object to an interface, and then modify that interface to add all the new DOM methods). ## How did you test this change? Manually synced `ReactNativeTypes` on top of facebook#49602 and verified Flow passes. DiffTrain build for [9dd378ff1222335ff133bab2d61001fcc84a1c56](facebook/react@9dd378f) Reviewed By: poteto Differential Revision: D70091830 fbshipit-source-id: 2cc49d8ed89e8ee2531dbc4094ef9720fc3040ad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Attempting to fix the public CI failure for
KeyError: 'fbandroid_compiler_flags'Changelog:
[Internal] [Changed] - Fix Buck failure for KeyError: 'fbandroid_compiler_flags'
Differential Revision: D31797803