Remove optional codegen config inside template#33108
Closed
ShikaSD wants to merge 1 commit intofacebook:mainfrom
Closed
Remove optional codegen config inside template#33108ShikaSD wants to merge 1 commit intofacebook:mainfrom
ShikaSD wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: The codegen config is optional and can be removed from the default package.json configuration in the template to simplify 0.68 upgrade for people who are not opted-in to the new arch. Changelog: [Internal] - Remove optional codegenConfig field from template Differential Revision: D34216988 fbshipit-source-id: e7deb11ffced4df03c20e4b00e009948d138ba99
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34216988 |
Base commit: f89a0b7 |
Base commit: f89a0b7 |
Collaborator
|
This pull request was successfully merged by @ShikaSD in a86c521. When will my fix make it into a release? | Upcoming Releases |
ShikaSD
pushed a commit
that referenced
this pull request
Feb 24, 2022
Summary: Pull Request resolved: #33108 The codegen config is optional and can be removed from the default package.json configuration in the template to simplify 0.68 upgrade for people who are not opted-in to the new arch. Changelog: [Internal] - Remove optional codegenConfig field from template Reviewed By: cortinico Differential Revision: D34216988 fbshipit-source-id: 5c448472eed99bc112aef204c4025454171a83c5
leotm
added a commit
to leotm/react-native-template-new-architecture
that referenced
this pull request
Feb 25, 2022
- Update app new arch Gradle build config - Add RubyGems lockfile (check why missing online: upgrade-helper/?from=0.68.0-rc.0&to=0.68.0-rc.1) - Keep: facebook/react-native#33108 for codegen config later ├─┬ react-native-gradle-plugin@0.0.5 │ └── react-native-codegen@0.0.13 ├─┬ react-native-screens@3.12.0 │ └─┬ react-native-gradle-plugin@0.0.3 │ └── react-native-codegen@0.0.13 └─┬ react-native@0.68.0-rc.2 └── react-native-codegen@0.0.13
This was referenced Apr 21, 2022
This was referenced Nov 14, 2022
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: Pull Request resolved: facebook#33108 The codegen config is optional and can be removed from the default package.json configuration in the template to simplify 0.68 upgrade for people who are not opted-in to the new arch. Changelog: [Internal] - Remove optional codegenConfig field from template Reviewed By: cortinico Differential Revision: D34216988 fbshipit-source-id: 5c448472eed99bc112aef204c4025454171a83c5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The codegen config is optional and can be removed from the default package.json configuration in the template to simplify 0.68 upgrade for people who are not opted-in to the new arch.
Changelog: [Internal] - Remove optional codegenConfig field from template
Differential Revision: D34216988