Pin use-subscription to < 1.6.0#33541
Conversation
Base commit: 16397e0 |
Starting with 1.6.0 this package relies on react 18 which is currently not supported by rn
0aa68df to
53d2ce1
Compare
Base commit: 16397e0 |
|
Thanks for adding the fix. I agree this workaround will mitigate the dependency issue. Will import and ship soon. |
|
@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @ryancat thanks for the import! Any feedback on why the internal tests fail? |
|
This pull request was successfully merged by @danilobuerger in 5534634. When will my fix make it into a release? | Upcoming Releases |
There were some internal dependencies updates and validations that failed. I had to make more changes beyond just update the semver in one place. But it went through after some digging :) |
|
Thanks! |
Summary: Starting with 1.6.0 this package relies on react 18 which is currently not supported by rn See https://github.com/facebook/react/blob/main/packages/use-subscription/package.json#L18 Fixes #33540 ## Changelog [General] [Fixed] - Pin use-subscription to < 1.6.0 Pull Request resolved: #33541 Test Plan: Run `yarn` in the following directories: `xplat/js/RKJSModules` `xplat/js/react-native-github` (Identified from jest test) `xplat/js/public` (Identified from yarn-validate) `js1 build buckfiles` (From diff signals) Reviewed By: yungsters Differential Revision: D35333789 Pulled By: ryancat fbshipit-source-id: bdb6232ccd2c5cece397f781609af2de7d36c5ff
Summary: Starting with 1.6.0 this package relies on react 18 which is currently not supported by rn See https://github.com/facebook/react/blob/main/packages/use-subscription/package.json#L18 Fixes facebook#33540 [General] [Fixed] - Pin use-subscription to < 1.6.0 Pull Request resolved: facebook#33541 Test Plan: Run `yarn` in the following directories: `xplat/js/RKJSModules` `xplat/js/react-native-github` (Identified from jest test) `xplat/js/public` (Identified from yarn-validate) `js1 build buckfiles` (From diff signals) Reviewed By: yungsters Differential Revision: D35333789 Pulled By: ryancat fbshipit-source-id: bdb6232ccd2c5cece397f781609af2de7d36c5ff
Summary
Starting with 1.6.0 this package relies on react 18 which is currently not supported by rn
See https://github.com/facebook/react/blob/main/packages/use-subscription/package.json#L18
Fixes #33540
Changelog
[General] [Fixed] - Pin use-subscription to < 1.6.0
Test Plan
no test plan