Added userInterfaceStyle to Alert to override user interface style for iOS 13+#33553
Closed
luoxuhai wants to merge 1 commit intofacebook:mainfrom
Closed
Added userInterfaceStyle to Alert to override user interface style for iOS 13+#33553luoxuhai wants to merge 1 commit intofacebook:mainfrom
luoxuhai wants to merge 1 commit intofacebook:mainfrom
Conversation
Base commit: 9f1fa91 |
Base commit: 9f1fa91 |
Contributor
|
Thanks for working on this! I am going to import the change and hopefully get shipped soon. |
Contributor
|
@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@ryancat cc: @lunaleaps Do you think this comment is related to this pull request change?
|
ken0nek
reviewed
Apr 5, 2022
bcf26e4 to
925c53a
Compare
Contributor
|
@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @luoxuhai in 47bd78f. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support to override Alert interface style to match your app. For example, You want to change the style on the alert.
Changelog
[iOS] [Added] - Add userInterfaceStyle to Alert to override user interface style for iOS 13+
Test Plan
userInterfaceStyle: 'light':userInterfaceStyle: 'dark':