Building new architecture sources on Windows (NDK Bump)

[mganandraj]

On Windows there are limits on number of character in file paths and in command lines
Ref: https://android.googlesource.com/platform/ndk/+/master/docs/BuildSystemMaintainers.md#Path-Length-Limits

The new architecutre source tree is too deep, and the object file naming conventions in NDK makes the matters worse, by producing incredibly long file paths.

Windows can support long file paths if configured through registry or by prefixing all file paths with a special character sequence. LLVM tools can work with long paths if user configured it but NDK23- uses binutils tools which don't.
This PR bumps NDK when building on Windows

Even with NDKr23, we are hitting the command line limits of 8191 characters !
NDK_APP_LOCAL_COMMANDS should come to rescue, but gradle android plugin has hardcoded the flag to false
Ref: Line#165 in https://android.googlesource.com/platform/tools/base/+/gradle_2.3.0/build-system/gradle-core/src/main/java/com/android/build/gradle/tasks/NdkBuildExternalNativeJsonGenerator.java#165

Hence, we can't use the default build directory. But, we can support much longer paths than without the NDK bump.

Changelog:
[Android] [Fixed] - Fix for building new architecture sources on Windows

On Windows there are limits on number of character in file paths and in command lines
Ref: https://android.googlesource.com/platform/ndk/+/master/docs/BuildSystemMaintainers.md#Path-Length-Limits

The new architecutre source tree is too deep, and the object file naming conventions in NDK makes the matters worse, by producing incredibly long file paths.

Windows can support long file paths if configured through registry or by prefixing all file paths with a special character sequence. LLVM tools can work with long paths if user configured it but NDK23- uses binutils tools which don't.
This PR bumps NDK when building on Windows

Even with NDKr23, we are hitting the command line limits of 8191 characters !
NDK_APP_LOCAL_COMMANDS should come to rescue, but gradle android plugin has hardcoded the flag to false
Ref: Line#165 in https://android.googlesource.com/platform/tools/base/+/gradle_2.3.0/build-system/gradle-core/src/main/java/com/android/build/gradle/tasks/NdkBuildExternalNativeJsonGenerator.java#165

Hence, we can't use the default build directory. But, we can support much longer paths than without the NDK bump.

Summary

Make sure react native apps can be build on windows machines.

Changelog

On Windows there are limits on number of character in file paths and in command lines
Ref: https://android.googlesource.com/platform/ndk/+/master/docs/BuildSystemMaintainers.md#Path-Length-Limits

The new architecutre source tree is too deep, and the object file naming conventions in NDK makes the matters worse, by producing incredibly long file paths.

Windows can support long file paths if configured through registry or by prefixing all file paths with a special character sequence. LLVM tools can work with long paths if user configured it but NDK23- uses binutils tools which don't.
This PR bumps NDK when building on Windows

Even with NDKr23, we are hitting the command line limits of 8191 characters !
NDK_APP_LOCAL_COMMANDS should come to rescue, but gradle android plugin has hardcoded the flag to false
Ref: Line#165 in https://android.googlesource.com/platform/tools/base/+/gradle_2.3.0/build-system/gradle-core/src/main/java/com/android/build/gradle/tasks/NdkBuildExternalNativeJsonGenerator.java#165

Hence, we can't use the default build directory. But, we can support much longer paths than without the NDK bump.

[CATEGORY] [TYPE] - Message

Test Plan

[pull-bot]

	Fails
🚫	node` failed.

Log

Error:  RequestError [HttpError]: Must have admin rights to Repository.
    at /root/react-native/bots/node_modules/@octokit/request/dist-node/index.js:86:21
    at processTicksAndRejections (internal/process/task_queues.js:95:5) {
  status: 403,
  response: {
    url: 'https://api.github.com/repos/facebook/react-native/issues/33627/labels',
    status: 403,
    headers: {
      'access-control-allow-origin': '*',
      'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
      connection: 'close',
      'content-encoding': 'gzip',
      'content-security-policy': "default-src 'none'",
      'content-type': 'application/json; charset=utf-8',
      date: 'Wed, 13 Apr 2022 06:30:51 GMT',
      'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
      server: 'GitHub.com',
      'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
      'transfer-encoding': 'chunked',
      vary: 'Accept-Encoding, Accept, X-Requested-With',
      'x-accepted-oauth-scopes': '',
      'x-content-type-options': 'nosniff',
      'x-frame-options': 'deny',
      'x-github-media-type': 'github.v3; format=json',
      'x-github-request-id': 'BDBE:1EE6:DFD1BF:194A86F:62566E1B',
      'x-oauth-scopes': 'public_repo',
      'x-ratelimit-limit': '5000',
      'x-ratelimit-remaining': '4992',
      'x-ratelimit-reset': '1649835049',
      'x-ratelimit-resource': 'core',
      'x-ratelimit-used': '8',
      'x-xss-protection': '0'
    },
    data: {
      message: 'Must have admin rights to Repository.',
      documentation_url: 'https://docs.github.com/rest/reference/issues#add-labels-to-an-issue'
    }
  },
  request: {
    method: 'POST',
    url: 'https://api.github.com/repos/facebook/react-native/issues/33627/labels',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'octokit.js/16.43.2 Node.js/14.18.1 (Linux 5.13; x64)',
      authorization: 'token [REDACTED]',
      'content-type': 'application/json; charset=utf-8'
    },
    body: '{"labels":["Pick Request"]}',
    request: { hook: [Function: bound bound register] }
  }
}
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against bea84f6

[mganandraj]

@cortinico This change is adding the ndk upgrade above the other PR .. This allows us to be more liberal on the host application path length ..

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 86f8d0b
Branch: main

[cortinico]

@cortinico This change is adding the ndk upgrade above the other PR .. This allows us to be more liberal on the host application path length ..

Thanks for doing this @mganandraj

We ended up picking this other two PRs:

• Building new architecture sources on Windows #33582
• Use NDK 23 only for Windows users. #33611
  Which were equivalent to this and would not cause a merge conflict.

Thanks again for your testing and support in solving this and unblocking 0.68.1 🙏