RN: Switch to Choco-Install from Windows Hermes CI
#34811
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Moves the `retry3` utility function into its own file so that it can be reused in other steps that are not related to Android. Changelog: [Internal] Differential Revision: D39889996 fbshipit-source-id: a879b665a94c78827629b901d053760b1532ca29
Summary: I am not totally sure whether this will work, so putting up a PR to see what happens. See: actions/runner-images#721 Changelog: [Internal] Differential Revision: D39890407 fbshipit-source-id: 567ba9926d8fa696163d5e0a97e057da0e9c666d
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39890407 |
yungsters
changed the title
Choco-Install from Windows Hermes CIChoco-Install from Windows Hermes CI
Base commit: 7f061f8 |
Base commit: 7f061f8 |
Collaborator
|
This pull request was successfully merged by @yungsters in 1a28058. When will my fix make it into a release? | Upcoming Releases |
Contributor
|
This pull request has been reverted by 8bb9717. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#34811 Switches the Windows Hermes CI step to use `Choco-Install` which implicitly supports retries for more reliable builds. See: actions/runner-images#721 Changelog: [Internal] Reviewed By: rickhanlonii Differential Revision: D39890407 fbshipit-source-id: 69c03845d2f2160fb39219dd4a5fff90a00de278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Switches the Windows Hermes CI step to use
Choco-Installwhich implicitly supports retries for more reliable builds.See: actions/runner-images#721
Changelog:
[Internal]
Differential Revision: D39890407