Fix issues for nightly build by Kudo · Pull Request #34846 · facebook/react-native

Kudo · 2022-10-03T12:08:48Z

Summary

There are two issues from nightly builds.

1. `VERSION_NAME=1000.0.0-main` in ReactAndroid/gradle.properties

the solution is to remove unused ReactAndroid/gradle.properties git revert when publishing package.

2. `pod install` error from downloading hermes, e.g. the url is unavailable. `https://github.com/facebook/react-native/releases/download/v0.0.0-20221002-2027-2319f75c8/hermes-runtime-darwin-debug-v0.0.0-20221002-2027-2319f75c8.tar.gz`

fix hermes-engine.podspec to support nightly build and build hermes from main branch.

Changelog

[General] [Fixed] - Fix nightly build issues

Test Plan

i cannot fully test publish-npm.js workflow and it stops at npm publish. i can just check at this moment, the ReactAndroid/gradle.properties is right.
create a npx react-native init project and yarn add react-native@nightly. patch node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec and try pod install

analysis-bot · 2022-10-03T12:39:00Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,739,161	+0
android	hermes	armeabi-v7a	7,141,579	+0
android	hermes	x86	8,050,059	+0
android	hermes	x86_64	8,021,773	+0
android	jsc	arm64-v8a	9,607,326	+0
android	jsc	armeabi-v7a	8,372,583	+0
android	jsc	x86	9,554,794	+0
android	jsc	x86_64	10,147,276	+0

Base commit: 9d08d55
Branch: main

cortinico · 2022-10-03T13:52:28Z

sdks/hermes-engine/hermes-engine.podspec

  Pod::UI.puts '[Hermes] Using pre-built Hermes binaries from local path.' if Object.const_defined?("Pod::UI")
  source[:http] = "file://#{ENV['HERMES_ENGINE_TARBALL_PATH']}"
-elsif version == '1000.0.0'
+elsif version == '1000.0.0' || version.start_with?('0.0.0-')


This is going to change soon as we're looking for a place where to store hermes tarballs also for nightlies: react-native-community/discussions-and-proposals#508

that's super helpful where we could test nightly without building hermes from source 🎉

cortinico · 2022-10-03T13:53:13Z

cc @kelset as you've been working on this recently

facebook-github-bot · 2022-10-03T13:54:06Z

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

kelset · 2022-10-03T13:55:40Z

hey @Kudo - for context, I've done changes in this area of the code in two places:

lmk if there's anything I need to modify over there to ensure everything works correctly

Kudo · 2022-10-03T14:54:37Z

hey @Kudo - for context, I've done changes in this area of the code in two places:

infra(e2e): rework local E2E script #34513

chore: re-align version to be 1000.0.0 on main everywhere #34817

lmk if there's anything I need to modify over there to ensure everything works correctly

thanks for these information @kelset. the pr is not in hurry at all, as at expo we have some postinstall workaround to fix these issues. i can wait your prs to be landed first and see if there're any necessary changes then.

Kudo · 2022-10-03T15:22:55Z

oh no this pr landed first, sorry @kelset 😅 let me know if there's anything i can help for your prs .

kelset · 2022-10-03T15:24:44Z

ahah no worries, I'll probably have a new small merge conflict to handle but everything should be fine 👍

react-native-bot · 2022-10-03T15:25:05Z