Resolve redirects instead of manually downloading nightly Hermes #38920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48225199 |
Base commit: 8fa584f |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Aug 10, 2023
…ebook#38920) Summary: Pull Request resolved: facebook#38920 Maven does not provide stable URLs for stored artifacts. Instead there can be a series of redirects for the actual download URL. CocoaPods does not follow redirects when such URL is set as a `source` in a `podspec`. To mitigate that we download Hermes prebuild manually, and that set the `source` to that file. This diff removes this manual download step, and utilizes `curl` to resolve redirects, and then assign final endpoint to `source[:http]` of the `hermes-engine.podspec`. Changelog: [Internal] - Resolve redirects instead of manually downloading nightly Hermes. Reviewed By: cipolleschi Differential Revision: D48225199 fbshipit-source-id: ffe112fcd5bc31bb21c9d2e905084f9824a5a072
dmytrorykun
force-pushed
the
export-D48225199
branch
from
9e72cd8 to
76c27f3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48225199 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48225199 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Aug 11, 2023
…ebook#38920) Summary: Pull Request resolved: facebook#38920 Maven does not provide stable URLs for stored artifacts. Instead there can be a series of redirects for the actual download URL. CocoaPods does not follow redirects when such URL is set as a `source` in a `podspec`. To mitigate that we download Hermes prebuild manually, and that set the `source` to that file. This diff removes this manual download step, and utilizes `curl` to resolve redirects, and then assign final endpoint to `source[:http]` of the `hermes-engine.podspec`. Changelog: [Internal] - Resolve redirects instead of manually downloading nightly Hermes. Reviewed By: cipolleschi Differential Revision: D48225199 fbshipit-source-id: 511372f847414a065f30df42d68108d4162b7394
dmytrorykun
force-pushed
the
export-D48225199
branch
from
76c27f3 to
e4a86fe
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Aug 21, 2023
…ebook#38920) Summary: Pull Request resolved: facebook#38920 Maven does not provide stable URLs for stored artifacts. Instead there can be a series of redirects for the actual download URL. CocoaPods does not follow redirects when such URL is set as a `source` in a `podspec`. To mitigate that we download Hermes prebuild manually, and that set the `source` to that file. This diff removes this manual download step, and utilizes `curl` to resolve redirects, and then assign final endpoint to `source[:http]` of the `hermes-engine.podspec`. Changelog: [Internal] - Resolve redirects instead of manually downloading nightly Hermes. Reviewed By: cipolleschi Differential Revision: D48225199 fbshipit-source-id: 2e3a16bb043856317618db728980080b9c7dbe63
dmytrorykun
force-pushed
the
export-D48225199
branch
from
e4a86fe to
35fa92b
Compare
…ebook#38920) Summary: Pull Request resolved: facebook#38920 Maven does not provide stable URLs for stored artifacts. Instead there can be a series of redirects for the actual download URL. CocoaPods does not follow redirects when such URL is set as a `source` in a `podspec`. To mitigate that we download Hermes prebuild manually, and that set the `source` to that file. This diff removes this manual download step, and utilizes `curl` to resolve redirects, and then assign final endpoint to `source[:http]` of the `hermes-engine.podspec`. Changelog: [Internal] - Resolve redirects instead of manually downloading nightly Hermes. Reviewed By: cipolleschi Differential Revision: D48225199 fbshipit-source-id: 6d41adadf5f1be429d2cce3924e6646cad8487fd
dmytrorykun
force-pushed
the
export-D48225199
branch
from
35fa92b to
6180e36
Compare
Contributor
|
This pull request has been merged in 52e54ed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Maven does not provide stable URLs for stored artifacts. Instead there can be a series of redirects for the actual download URL.
CocoaPods does not follow redirects when such URL is set as a
sourcein apodspec. To mitigate that we download Hermes prebuild manually, and that set thesourceto that file.This diff removes this manual download step, and utilizes
curlto resolve redirects, and then assign final endpoint tosource[:http]of thehermes-engine.podspec.Changelog: [Internal] - Resolve redirects instead of manually downloading nightly Hermes.
Reviewed By: cipolleschi
Differential Revision: D48225199