Skip to content

Conversation

@javache
Copy link
Member

@javache javache commented Aug 30, 2023

Summary:
Some tests were not running because they were disabled when experiment with enableCalculateTransformedFrames. Instead, run tests against both variants of the experiment so differences can be better understood.

Changelog: [Internal]

Differential Revision: D48826739

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 30, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48826739

@analysis-bot
Copy link

analysis-bot commented Aug 30, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,962,760 +86
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,555,997 +27
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 9552ed0
Branch: main

Summary:
Pull Request resolved: facebook#39211

Some tests were not running because they were disabled when experiment with `enableCalculateTransformedFrames`. Instead, run tests against both variants of the experiment so differences can be better understood.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D48826739

fbshipit-source-id: 7b4263ca2441cbe2fa94a92f64364e1fca7ec0d3
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48826739

@github-actions
Copy link

Warnings
⚠️

E2E tests for ci/circleci: test_e2e_ios failed with errors. See the logs for details

⚠️

E2E tests for ci/circleci: test_e2e_ios failed with errors. See the logs for details

Generated by 🚫 dangerJS against a5bafff

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 31, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in c66d570.

@javache javache deleted the export-D48826739 branch September 1, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants