SVC Codegen: Handle TSAsExpression when looking for the codegen declaration#40860
Closed
dmytrorykun wants to merge 1 commit intofacebook:mainfrom
Closed
SVC Codegen: Handle TSAsExpression when looking for the codegen declaration#40860dmytrorykun wants to merge 1 commit intofacebook:mainfrom
dmytrorykun wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50225241 |
dmytrorykun
force-pushed
the
export-D50225241
branch
from
50bb010 to
adf44a6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50225241 |
…ration (facebook#40860) Summary: This diff adds support for the `AS` expression in TS sources. The following codegen declaration should work now: ``` export default codegenNativeComponent<NativeProps>( 'MyComponentView', ) as HostComponent<NativeProps>; ``` Changelog: [General][Added] - Handle TSAsExpression when looking for the codegen declaration Reviewed By: shwanton Differential Revision: D50225241
dmytrorykun
force-pushed
the
export-D50225241
branch
from
adf44a6 to
2902cc5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50225241 |
|
This pull request was successfully merged by @dmytrorykun in 0295771. When will my fix make it into a release? | Upcoming Releases |
Contributor
|
This pull request has been merged in 0295771. |
blakef
pushed a commit
that referenced
this pull request
Jan 25, 2024
…ration (#40860) Summary: Pull Request resolved: #40860 This diff adds support for the `AS` expression in TS sources. The following codegen declaration should work now: ``` export default codegenNativeComponent<NativeProps>( 'MyComponentView', ) as HostComponent<NativeProps>; ``` Changelog: [General][Added] - Handle TSAsExpression when looking for the codegen declaration Reviewed By: shwanton Differential Revision: D50225241 fbshipit-source-id: 247a3d341d742b548e82318d0fa21dff9884d2bd
This was referenced Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds support for the
ASexpression in TS sources. The following codegen declaration should work now:Changelog: [General][Added] - Handle TSAsExpression when looking for the codegen declaration
Differential Revision: D50225241