Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50176083 |
Base commit: bbc517c |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50176083 |
javache
force-pushed
the
export-D50176083
branch
from
d944f3d to
be89eda
Compare
javache
force-pushed
the
export-D50176083
branch
from
be89eda to
d57a837
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50176083 |
javache
force-pushed
the
export-D50176083
branch
from
d57a837 to
561b160
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50176083 |
javache
force-pushed
the
export-D50176083
branch
from
561b160 to
7802cc5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50176083 |
javache
force-pushed
the
export-D50176083
branch
from
7802cc5 to
c29658a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50176083 |
javache
force-pushed
the
export-D50176083
branch
from
c29658a to
e04db8a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50176083 |
javache
force-pushed
the
export-D50176083
branch
from
e04db8a to
b169daf
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50176083 |
javache
force-pushed
the
export-D50176083
branch
from
b169daf to
b530ba4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50176083 |
javache
force-pushed
the
export-D50176083
branch
from
b530ba4 to
90603d7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50176083 |
javache
force-pushed
the
export-D50176083
branch
from
90603d7 to
192214f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50176083 |
Summary: Changelog: [Internal] Use JSI's NativeState abstraction to reference C++ objects across JS calls Reviewed By: rubennorte, sammy-SC Differential Revision: D50176083
javache
force-pushed
the
export-D50176083
branch
from
192214f to
7399f5d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50176083 |
Generated by 🚫 dangerJS against 192214fd6196dd4c6b0270d59ea9d56fcf7d5c66 |
Contributor
|
This pull request has been merged in f308f02. |
Contributor
|
@javache why was |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
…gain (#45290) Summary: This PR restores the virtual destructor for `ShadowNodeWrapper` which was added in #33500 and unfortunately removed in #40864. The virtual destructor here serves as a key function. Without a key function, `obj.hasNativeState<ShadowNodeWrapper>(rt)` **does not** work correctly between shared library boundaries on Android and always returns false. We need this pretty badly in third-party libraries like react-native-reanimated or react-native-gesture-handler. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [FIXED] - Fix dynamic_cast (RTTI) for ShadowNodeWrapper when accessed by third-party libraries again Pull Request resolved: #45290 Test Plan: This patch fixes an issue in Reanimated's fabric-example app. Reviewed By: fabriziocucci Differential Revision: D59375554 Pulled By: javache fbshipit-source-id: 09f3eda89a67c26d6dacca3428e08d1b7138d350
cipolleschi
pushed a commit
that referenced
this pull request
Jul 8, 2024
…gain (#45290) Summary: This PR restores the virtual destructor for `ShadowNodeWrapper` which was added in #33500 and unfortunately removed in #40864. The virtual destructor here serves as a key function. Without a key function, `obj.hasNativeState<ShadowNodeWrapper>(rt)` **does not** work correctly between shared library boundaries on Android and always returns false. We need this pretty badly in third-party libraries like react-native-reanimated or react-native-gesture-handler. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [FIXED] - Fix dynamic_cast (RTTI) for ShadowNodeWrapper when accessed by third-party libraries again Pull Request resolved: #45290 Test Plan: This patch fixes an issue in Reanimated's fabric-example app. Reviewed By: fabriziocucci Differential Revision: D59375554 Pulled By: javache fbshipit-source-id: 09f3eda89a67c26d6dacca3428e08d1b7138d350
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [Internal] Use JSI's NativeState abstraction to reference C++ objects across JS calls
Reviewed By: sammy-SC
Differential Revision: D50176083