Skip to content

Fix comment about adding packages in android template #41856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
janicduplessis wants to merge 6 commits into from
Closed

Fix comment about adding packages in android template #41856

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8aca4bb
Fix comment about adding packages in android template
janicduplessis Dec 8, 2023
17d58f8
Update packages/react-native/template/android/app/src/main/java/com/h…
janicduplessis Dec 8, 2023
72107de
Update MainApplication.kt
janicduplessis Dec 8, 2023
34b994c
Update MainApplication.kt
janicduplessis Dec 8, 2023
4e52572
Update MainApplication.kt
janicduplessis Dec 12, 2023
cab12a2
Update packages/react-native/template/android/app/src/main/java/com/h…
janicduplessis Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/react-native/template/android/app/src/main/java/com/helloworld/MainApplication.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ class MainApplication : Application(), ReactApplication {

override val reactNativeHost: ReactNativeHost =
object : DefaultReactNativeHost(this) {
Copy link

@aajahid aajahid Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mix usages of 4 space tab and 2 space tab bothering me a lot 😞

Can I make PR? ( asking cause this doesn't resolve or implement anything )

Copy link
Contributor

@cortinico cortinico Jan 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is autoformatted by ktfmt, so even if you send a PR that attempts to fix this, it will be reformatted back to how it is now

override fun getPackages(): List<ReactPackage> {
// Packages that cannot be autolinked yet can be added manually here, for example:
// packages.add(new MyReactNativePackage());
return PackageList(this).packages
}
override fun getPackages(): List<ReactPackage> =
PackageList(this).packages.apply {
// Packages that cannot be autolinked yet can be added manually here, for example:
// add(MyReactNativePackage())
}

override fun getJSMainModuleName(): String = "index"

Expand Down