Skip to content

Remove * dependencies on @react-native#42081

Closed
lunaleaps wants to merge 1 commit intomainfrom
lunaleaps-remove-star-deps
Closed

Remove * dependencies on @react-native#42081
lunaleaps wants to merge 1 commit intomainfrom
lunaleaps-remove-star-deps

Conversation

@lunaleaps
Copy link
Copy Markdown
Contributor

@lunaleaps lunaleaps commented Dec 27, 2023

Summary:

See #41929 for an issue on multiple monorepo packages being installed. The reason is that * resolves to whatever is tagged latest on npm.

We still need to fix the fact that our monorepo publish script will update the latest tag everytime we publish. For now, we should remove these from main and we will also update this in the 0.73 release branch.

I've left the two peer dependencies on react-native to keep at *.

virtualized-lists/package.json
30:    "react-native": "*"

rn-tester/package.json
32:    "react-native": "*"

As a peer-dependency this won't be a problem in terms of installing a second react-native. I thought about updating these to nightly, but that would install multiple nightly react-natives as the tag will be updated with each nightly release. I think for now this is fine and something we can revisit.

Things left to do

Changelog:

[GENERAL] [CHANGED] - Be explicit about what monorepo versions we are using

Test Plan:

N/A

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Dec 27, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,577,952 -13
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,955,034 -4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: c75abef
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@lunaleaps merged this pull request in b5e08e8.

@cortinico cortinico deleted the lunaleaps-remove-star-deps branch June 10, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants