Skip to content

Export rotation property for views #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jparishy wants to merge 6 commits into from
Closed

Export rotation property for views #423

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bcf2368
Add custom property for rotation to RCTViewManager.m
Mar 29, 2015
a5fb130
Export the rotation property in RCTViewManager.m
Mar 29, 2015
1bff03c
Merge branch 'master' of https://github.com/facebook/react-native
Mar 29, 2015
85c33b5
Merge branch 'master' into export-rotation-property-for-views
Mar 29, 2015
b4e7e41
Inline the brackets for the if-else statement
Mar 29, 2015
0bd79d2
Space after if statement to match FB sytle
Mar 29, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions React/Views/RCTViewManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,16 @@ - (RCTViewManagerUIBlock)uiBlockToAmendWithShadowViewRegistry:(RCTSparseArray *)
RCT_REMAP_VIEW_PROPERTY(shadowOpacity, layer.shadowOpacity, CGFloat)
RCT_REMAP_VIEW_PROPERTY(shadowRadius, layer.shadowRadius, CGFloat)
RCT_REMAP_VIEW_PROPERTY(transformMatrix, layer.transform, CATransform3D)
RCT_CUSTOM_VIEW_PROPERTY(rotation, CGFloat, RCTView)
{
if (json) {
CGFloat angle = [RCTConvert CGFloat:json];
Copy link
Contributor

@tadeuzagallo tadeuzagallo Mar 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @vjeux do you think we should use degrees instead of radians?

Copy link
Author

@jparishy jparishy Mar 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I think it would be nice to take radians by default and provide degrees() and radians() functions in JavaScript to do the appropriate conversions

CGAffineTransform transform = CGAffineTransformRotate(view.transform, angle);
view.transform = transform;
} else {
view.transform = defaultView.transform;
}
Copy link
Contributor

@fisherwebdev fisherwebdev Mar 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the else block need to be here?

Copy link
Author

@jparishy jparishy Mar 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fisherwebdev it might not be needed, I suppose. My understanding was that it would reset the transform in the case where rotation: null is found in the JSON, which I picked up from the convention of the other custom view properties. I could be wrong though, in which case I can remove it.

}
RCT_CUSTOM_VIEW_PROPERTY(overflow, css_overflow, RCTView)
{
view.clipsToBounds = json ? ![RCTConvert css_overflow:json] : defaultView.clipsToBounds;
Expand Down