Add react-native-test-library package #43068
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50793835 |
dcangulo
reviewed
Feb 16, 2024
| s.license = package['license'] | ||
| s.platforms = min_supported_versions | ||
| s.author = 'Meta Platforms, Inc. and its affiliates' | ||
| s.source = { :git => package['repository'], :tag => '#{s.version}' } |
Contributor
There was a problem hiding this comment.
I think this should be "#{s.version}" or just simply s.version.
Suggested change
| s.source = { :git => package['repository'], :tag => '#{s.version}' } | |
| s.source = { :git => package['repository'], :tag => s.version } |
dcangulo
reviewed
Feb 16, 2024
Contributor
dcangulo
left a comment
dcangulo
left a comment
There was a problem hiding this comment.
Just a string interpolation typo.
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Feb 16, 2024
Summary:
This diff adds `react-native-oss-library-example` package.
It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries.
It is integrated with RNTester as the **OSS Library Example** screen.
{F1457510909}
**Change Background** tests native commands.
**Set Opacity** tests native props.
**Get Random Number** tests native module.
Changelog: [Internal]
Differential Revision: D50793835
dmytrorykun
force-pushed
the
export-D50793835
branch
from
fbef1a2 to
78fb475
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50793835 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Feb 16, 2024
Summary:
This diff adds `react-native-oss-library-example` package.
It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries.
It is integrated with RNTester as the **OSS Library Example** screen.
{F1457510909}
**Change Background** tests native commands.
**Set Opacity** tests native props.
**Get Random Number** tests native module.
Changelog: [Internal]
Differential Revision: D50793835
dmytrorykun
force-pushed
the
export-D50793835
branch
from
78fb475 to
2781e62
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50793835 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Feb 16, 2024
Summary:
This diff adds `react-native-oss-library-example` package.
It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries.
It is integrated with RNTester as the **OSS Library Example** screen.
{F1457510909}
**Change Background** tests native commands.
**Set Opacity** tests native props.
**Get Random Number** tests native module.
Changelog: [Internal]
Differential Revision: D50793835
dmytrorykun
changed the title
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Feb 16, 2024
Summary:
This diff adds `react-native-test-library` package.
It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries.
It is integrated with RNTester as the **OSS Library Example** screen.
{F1457510909}
**Change Background** tests native commands.
**Set Opacity** tests native props.
**Get Random Number** tests native module.
Changelog: [Internal]
Differential Revision: D50793835
dmytrorykun
force-pushed
the
export-D50793835
branch
from
2781e62 to
02cbec6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50793835 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50793835 |
dmytrorykun
force-pushed
the
export-D50793835
branch
from
02cbec6 to
b662785
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43068 This diff adds `react-native-test-library` package. It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries. It is integrated with RNTester as the **OSS Library Example** screen. {F1457510909} **Change Background** tests native commands. **Set Opacity** tests native props. **Get Random Number** tests native module. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D50793835
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50793835 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43068 This diff adds `react-native-test-library` package. It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries. It is integrated with RNTester as the **OSS Library Example** screen. {F1457510909} **Change Background** tests native commands. **Set Opacity** tests native props. **Get Random Number** tests native module. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D50793835
dmytrorykun
force-pushed
the
export-D50793835
branch
from
b662785 to
f8e3485
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50793835 |
dmytrorykun
force-pushed
the
export-D50793835
branch
from
f8e3485 to
0b3f27c
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Apr 8, 2024
Summary: Pull Request resolved: facebook#43068 This diff adds `react-native-test-library` package. It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries. It is integrated with RNTester as the **OSS Library Example** screen. {F1457510909} **Change Background** tests native commands. **Set Opacity** tests native props. **Get Random Number** tests native module. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D50793835
Base commit: b23960a |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50793835 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Apr 8, 2024
Summary: Pull Request resolved: facebook#43068 This diff adds `react-native-test-library` package. It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries. It is integrated with RNTester as the **OSS Library Example** screen. {F1457510909} **Change Background** tests native commands. **Set Opacity** tests native props. **Get Random Number** tests native module. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D50793835
dmytrorykun
force-pushed
the
export-D50793835
branch
from
0b3f27c to
b844a91
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50793835 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Apr 8, 2024
Summary: Pull Request resolved: facebook#43068 This diff adds `react-native-test-library` package. It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries. It is integrated with RNTester as the **OSS Library Example** screen. {F1457510909} **Change Background** tests native commands. **Set Opacity** tests native props. **Get Random Number** tests native module. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D50793835
dmytrorykun
force-pushed
the
export-D50793835
branch
from
b844a91 to
0ba6987
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50793835 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Apr 8, 2024
Summary: Pull Request resolved: facebook#43068 This diff adds `react-native-test-library` package. It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries. It is integrated with RNTester as the **OSS Library Example** screen. {F1457510909} **Change Background** tests native commands. **Set Opacity** tests native props. **Get Random Number** tests native module. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D50793835
dmytrorykun
force-pushed
the
export-D50793835
branch
from
0ba6987 to
7ac29e4
Compare
Summary: Pull Request resolved: facebook#43068 This diff adds `react-native-test-library` package. It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries. It is integrated with RNTester as the **OSS Library Example** screen. {F1457510909} **Change Background** tests native commands. **Set Opacity** tests native props. **Get Random Number** tests native module. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D50793835
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50793835 |
dmytrorykun
force-pushed
the
export-D50793835
branch
from
7ac29e4 to
b2347a9
Compare
Contributor
|
This pull request has been merged in 1cb0a33. |
|
This pull request was successfully merged by @dmytrorykun in 1cb0a33. When will my fix make it into a release? | How to file a pick request? |
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds
react-native-test-librarypackage.It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries.
It is integrated with RNTester as the OSS Library Example screen.
{F1457510909}
Change Background tests native commands.
Set Opacity tests native props.
Get Random Number tests native module.
Changelog: [Internal]
Differential Revision: D50793835