Pass whole RuntimeTargetDelegate from RN instead of aggregating its methods #43346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54585658 |
…ethods (facebook#43346) Summary: Changelog: [Internal] (Continuing the theme of reducing integration boilerplate from D54537844.) This diff changes both `JSExecutor` (Bridge) and `JSRuntime` (Bridgeless) to no longer implement `RuntimeTargetDelegate`. Instead, each of them exposes a `getRuntimeTargetDelegate()` method that returns a stable reference to a target delegate that it *owns*. To facilitate this, we create a new `FallbackRuntimeTargetDelegate` for use in non-Hermes cases. This replaces *almost* all direct uses of `FallbackRuntimeAgentDelegate` outside of `jsinspector`. I'll follow up in a separate diff to deal with the last case and make the fallback agent delegate fully private. As a result, changing the `RuntimeTargetDelegate` interface (which we'll need to do for console support) becomes much easier: we only have unit test mocks + two concrete `RuntimeTargetDelegate` implementations (one fallback, one Hermes) to update for each API change. Differential Revision: D54585658
motiz88
force-pushed
the
export-D54585658
branch
from
eb5fdb5 to
24c361f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54585658 |
Base commit: 1c69100 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Mar 6, 2024
…ethods (facebook#43346) Summary: Changelog: [Internal] (Continuing the theme of reducing integration boilerplate from D54537844.) This diff changes both `JSExecutor` (Bridge) and `JSRuntime` (Bridgeless) to no longer implement `RuntimeTargetDelegate`. Instead, each of them exposes a `getRuntimeTargetDelegate()` method that returns a stable reference to a target delegate that it *owns*. To facilitate this, we create a new `FallbackRuntimeTargetDelegate` for use in non-Hermes cases. This replaces *almost* all direct uses of `FallbackRuntimeAgentDelegate` outside of `jsinspector`. I'll follow up in a separate diff to deal with the last case and make the fallback agent delegate fully private. As a result, changing the `RuntimeTargetDelegate` interface (which we'll need to do for console support) becomes much easier: we only have unit test mocks + two concrete `RuntimeTargetDelegate` implementations (one fallback, one Hermes) to update for each API change. Differential Revision: D54585658
Contributor
|
This pull request has been merged in 7c5a014. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
(Continuing the theme of reducing integration boilerplate from D54537844.)
This diff changes both
JSExecutor(Bridge) andJSRuntime(Bridgeless) to no longer implementRuntimeTargetDelegate. Instead, each of them exposes agetRuntimeTargetDelegate()method that returns a stable reference to a target delegate that it owns.To facilitate this, we create a new
FallbackRuntimeTargetDelegatefor use in non-Hermes cases. This replaces almost all direct uses ofFallbackRuntimeAgentDelegateoutside ofjsinspector. I'll follow up in a separate diff to deal with the last case and make the fallback agent delegate fully private.As a result, changing the
RuntimeTargetDelegateinterface (which we'll need to do for console support) becomes much easier: we only have unit test mocks + two concreteRuntimeTargetDelegateimplementations (one fallback, one Hermes) to update for each API change.Differential Revision: D54585658