add missing synchronisation call for native animated#43374
Closed
sammy-SC wants to merge 1 commit intofacebook:mainfrom
Closed
add missing synchronisation call for native animated#43374sammy-SC wants to merge 1 commit intofacebook:mainfrom
sammy-SC wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54582987 |
sammy-SC
force-pushed
the
export-D54582987
branch
from
35797ed to
3ac251a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54582987 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54582987 |
Summary: changelog: [internal] when animation that uses native driver finishes, it must synchronise the end state with shadow tree. `onUpdateRef` for native animated is only called when the animation finishes. Reviewed By: javache, yungsters Differential Revision: D54582987
sammy-SC
force-pushed
the
export-D54582987
branch
from
3ac251a to
b133b9e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54582987 |
|
This pull request was successfully merged by @sammy-SC in da91323. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
when animation that uses native driver finishes, it must synchronise the end state with shadow tree.
onUpdateReffor native animated is only called when the animation finishes.Reviewed By: javache, yungsters
Differential Revision: D54582987