Skip to content

delete ShadowNodeFragment::Value #43962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sammy-SC wants to merge 1 commit into from
Closed

delete ShadowNodeFragment::Value #43962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions packages/react-native/ReactCommon/react/renderer/core/ShadowNodeFragment.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,4 @@ const State::Shared& ShadowNodeFragment::statePlaceholder() {
return instance;
}

using Value = ShadowNodeFragment::Value;

Value::Value(const ShadowNodeFragment& fragment)
: props(fragment.props),
children(fragment.children),
state(fragment.state) {}

Value::operator ShadowNodeFragment() const {
return ShadowNodeFragment{props, children, state};
}

} // namespace facebook::react
24 changes: 0 additions & 24 deletions packages/react-native/ReactCommon/react/renderer/core/ShadowNodeFragment.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ namespace facebook::react {
* Note: Most of the fields are `const &` references (essentially just raw
* pointers) which means that the Fragment does not copy/store them nor
* retain ownership of them.
* Use `ShadowNodeFragment::Value` (see below) to create an owning copy of the
* fragment content to store or pass the data asynchronously.
*/
struct ShadowNodeFragment {
const Props::Shared& props = propsPlaceholder();
Expand All @@ -37,28 +35,6 @@ struct ShadowNodeFragment {
static const Props::Shared& propsPlaceholder();
static const ShadowNode::SharedListOfShared& childrenPlaceholder();
static const State::Shared& statePlaceholder();

/*
* `ShadowNodeFragment` is not owning data-structure, it only stores raw
* pointers to the data. `ShadowNodeFragment::Value` is a convenient owning
* counterpart of that.
*/
class Value final {
public:
/*
* Creates an object with given `ShadowNodeFragment`.
*/
Value(const ShadowNodeFragment& fragment);

/*
* Creates a `ShadowNodeFragment` from the object.
*/
explicit operator ShadowNodeFragment() const;

Props::Shared props;
ShadowNode::SharedListOfShared children;
State::Shared state;
};
};

} // namespace facebook::react