Skip to content

Add feature flag for shadow node reference updates#44769

Closed
lenaic wants to merge 1 commit intofacebook:mainfrom
lenaic:export-D57860868
Closed

Add feature flag for shadow node reference updates#44769
lenaic wants to merge 1 commit intofacebook:mainfrom
lenaic:export-D57860868

Conversation

@lenaic
Copy link

@lenaic lenaic commented Jun 3, 2024

Summary:
Changelog: [Internal]

Adding a feature flag to conditionally enable shadow node reference updates when cloning nodes within react native.

Reviewed By: sammy-SC

Differential Revision: D57860868

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 3, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57860868

@analysis-bot
Copy link

analysis-bot commented Jun 3, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,576,670 +67
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,946,189 +38
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: a6a7cdf
Branch: main

lenaic pushed a commit to lenaic/react-native-macos that referenced this pull request Jun 3, 2024
Summary:

Changelog: [Internal]

Adding a feature flag to conditionally enable shadow node reference updates when cloning nodes within react native.

Reviewed By: sammy-SC

Differential Revision: D57860868
Summary:

Changelog: [Internal]

Adding a feature flag to conditionally enable shadow node reference updates when cloning nodes within react native.

Reviewed By: sammy-SC

Differential Revision: D57860868
@lenaic lenaic force-pushed the export-D57860868 branch from 57d89f8 to 0a2d640 Compare June 4, 2024 00:42
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57860868

lenaic pushed a commit to lenaic/react-native-macos that referenced this pull request Jun 4, 2024
…k#44769)

Summary:

Changelog: [Internal]

Adding a feature flag to conditionally enable shadow node reference updates when cloning nodes within react native.

Reviewed By: sammy-SC

Differential Revision: D57860868
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 4, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 12411e9.

@github-actions
Copy link

github-actions bot commented Jun 4, 2024

This pull request was successfully merged by Nick Lefever in 12411e9.

When will my fix make it into a release? | How to file a pick request?

kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 11, 2024
Summary:
Pull Request resolved: facebook#44769

Changelog: [Internal]

Adding a feature flag to conditionally enable shadow node reference updates when cloning nodes within react native.

Reviewed By: sammy-SC

Differential Revision: D57860868

fbshipit-source-id: 5542257cd22d9020b3d98a53ca872b5bde3c5738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants