feat: include information about text range changes in onChange#45248
Closed
hannojg wants to merge 5 commits intofacebook:mainfrom
Closed
feat: include information about text range changes in onChange#45248hannojg wants to merge 5 commits intofacebook:mainfrom
hannojg wants to merge 5 commits intofacebook:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
This was referenced Jul 2, 2024
Base commit: c252460 |
hannojg
force-pushed
the
feat/native-text-range-updates
branch
3 times, most recently
from
e26ce7a to
ffb06f8
Compare
hannojg
force-pushed
the
feat/native-text-range-updates
branch
from
ffb06f8 to
5bcdda8
Compare
facebook-github-bot
added
the
Shared with Meta
hannojg
added a commit
to margelo/react-native-live-markdown
that referenced
this pull request
Jul 2, 2024
To align with react native, see: facebook/react-native#45248
Collaborator
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
added
the
Stale
Collaborator
|
This PR was closed because it has been stalled for 7 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This Pr provides a solution to:
By providing further information about the range in which a text has been changed in the
onChangeevent users are able to implement<TextInputs />that only apply partial text updates, thus avoiding race condition issues between the main/UI and JS thread.Changelog:
[ANDROID] [ADDED] - Add
start,before,countinfo to the Textinput'sonChangeevent[IOS] [ADDED] - Add
start,before,countinfo to the Textinput'sonChangeeventTest Plan:
I added an example to the rn-tester app.
Screen.Recording.2024-07-02.at.15.33.29.mov