Fix "Platform.constants.reactNativeVersion.prerelease" Flow and TypeScript types #45256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cript types Summary: The actual stamped versions here are all strings. Android interface for constants is untyped, and we always return a string here. iOS, we will try to parse the string into a double, which will fail for every prerelease version RN has ever published. Platform on Windows seems to uniquely be doing the right thing. Changelog: [General][Fixed] - Fix Platform.constants.reactNativeVersion type Differential Revision: D59141948
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59141948 |
Base commit: e35a2f4 |
Contributor
|
This pull request has been merged in 95d9cdf. |
|
This pull request was successfully merged by @NickGerleman in 95d9cdf. When will my fix make it into a release? | How to file a pick request? |
blakef
pushed a commit
that referenced
this pull request
Jul 15, 2024
…cript types (#45256) Summary: Pull Request resolved: #45256 The actual stamped versions here are all strings. Android interface for constants is untyped, and we always return a string here. iOS, we will try to parse the string into a double, which will fail for every prerelease version RN has ever published. Platform on Windows seems to uniquely be doing the right thing. Changelog: [General][Fixed] - Fix Platform.constants.reactNativeVersion type Reviewed By: robhogan, necolas Differential Revision: D59141948 fbshipit-source-id: 9c758e5eb8796b03197258d87ec06b31018e211c
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The actual stamped versions here are all strings.
Android interface for constants is untyped, and we always return a string here. iOS, we will try to parse the string into a double, which will fail for every prerelease version RN has ever published.
Platform on Windows seems to uniquely be doing the right thing.
Changelog:
[General][Fixed] - Fix Platform.constants.reactNativeVersion type
Differential Revision: D59141948