Add config version, and invalidate layout on config change #45259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59286992 |
Base commit: c0977c3 |
…45259) Summary: Pull Request resolved: facebook#45259 This is a continuation of the previous PR: facebook#45047 I made the change more generic for allowing any kind of config change to invalidate layout. X-link: facebook/yoga#1674 Reviewed By: rozele Differential Revision: D59286992 Pulled By: NickGerleman
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59286992 |
NickGerleman
force-pushed
the
export-D59286992
branch
from
3bd7da8 to
c26dd69
Compare
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Jul 3, 2024
Summary: X-link: facebook/react-native#45259 This is a continuation of the previous PR: facebook/react-native#45047 I made the change more generic for allowing any kind of config change to invalidate layout. Changelog: [Internal] X-link: facebook/yoga#1674 Reviewed By: rozele Differential Revision: D59286992 Pulled By: NickGerleman fbshipit-source-id: f46f35b03d5d9a743b798844ee3e1a02c271ccde
Contributor
|
@NickGerleman merged this pull request in 2939dfc. |
|
This pull request was successfully merged by @acoates-ms in 2939dfc. When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Jul 3, 2024
Summary: X-link: facebook/react-native#45259 This is a continuation of the previous PR: facebook/react-native#45047 I made the change more generic for allowing any kind of config change to invalidate layout. Changelog: [Internal] Pull Request resolved: #1674 Reviewed By: rozele Differential Revision: D59286992 Pulled By: NickGerleman fbshipit-source-id: f46f35b03d5d9a743b798844ee3e1a02c271ccde
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a continuation of the previous PR: #45047
I made the change more generic for allowing any kind of config change to invalidate layout.
X-link: facebook/yoga#1674
Differential Revision: D59286992
Pulled By: NickGerleman