remove gating for optimized text #45317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: changelog: [internal] ship optimized version of Text componant. In local benchmarking this version shows 35% improvement over old Text component. Differential Revision: D59460871
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59460871 |
Base commit: 258f41a |
iBotPeaches
reviewed
Jul 8, 2024
Comment on lines
+34
to
+36
| * NOTE: This file is a short term fork of `Text` for the purpose of performance | ||
| * testing. Any changes to either this component or `Text` should be avoided | ||
| * while this file exists. |
Contributor
There was a problem hiding this comment.
I guess its not much of the short-term fork anymore if its moved into main Text component. Same with the diffs below.
Contributor
Author
There was a problem hiding this comment.
thanks for noticing that! Let me remove it.
Contributor
|
This pull request has been merged in 9fbc904. |
|
This pull request was successfully merged by @sammy-SC in 9fbc904. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
ship optimized version of Text componant. In local benchmarking this version shows 35% improvement over old Text component.
Differential Revision: D59460871