Register Thread For Hermes Sampling #45331
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58787655 |
Summary: Let's add the a new JSRuntime API to register the thread. This allows Hermes sampling to correctly work in Bridgeless/Activity. ## Changelog: [General][Added] - Add experimental api to JSRuntimeFactory to initialize runtime on js thread Reviewed By: RSNara Differential Revision: D58787655
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58787655 |
Base commit: ead50d6 |
Contributor
|
This pull request has been merged in c9fbc05. |
|
This pull request was successfully merged by Benoit Girard in c9fbc05. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Let's add the a new JSI API to register the thread. This is a fairly Hermes specific need but it wouldn't hurt another runtime. This function is really an optional hint. This allows Hermes sampling to correctly work in Bridgeless/Activity.
Changelog:
[General][Added] - Add experimental api to JSRuntimeFactory to initialize runtime on js thread
Reviewed By: RSNara
Differential Revision: D58787655