Pass unflattened styles to reconciler #45345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59518281 |
Base commit: ef2e941 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59518281 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jul 9, 2024
Summary: Pull Request resolved: facebook#45345 When React diffs props, it can can short-circuit nested objects if their object identity hasn't changed. Whenever we use `flattenStyle` we prevent this optimization from taking place. Changelog: [Internal] Differential Revision: D59518281
Summary: Pull Request resolved: facebook#45345 When React diffs props, it can can short-circuit nested objects if their object identity hasn't changed. Whenever we use `flattenStyle` we prevent this optimization from taking place. Changelog: [Internal] Reviewed By: dmytrorykun Differential Revision: D59518281
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59518281 |
javache
force-pushed
the
export-D59518281
branch
from
fdff592 to
4101b45
Compare
Contributor
|
This pull request has been merged in d9d638c. |
Collaborator
|
This pull request was successfully merged by @javache in d9d638c When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When React diffs props, it can can short-circuit nested objects if their object identity hasn't changed. Whenever we use
flattenStylewe prevent this optimization from taking place.Changelog: [Internal]
Differential Revision: D59518281