Skip to content

Update comments for ~ShadowNodeWrapper() and ~ShadowNodeListWrapper()#45357

Closed
tomekzaw wants to merge 1 commit intofacebook:mainfrom
tomekzaw:@tomekzaw/update-comments-shadow-node-wrapper
Closed

Update comments for ~ShadowNodeWrapper() and ~ShadowNodeListWrapper()#45357
tomekzaw wants to merge 1 commit intofacebook:mainfrom
tomekzaw:@tomekzaw/update-comments-shadow-node-wrapper

Conversation

@tomekzaw
Copy link
Contributor

Summary:

This PR updates the comments for ~ShadowNodeWrapper() and ~ShadowNodeListWrapper() to align them with the actual implementation that now uses jsi::NativeState instead of jsi::HostObject.

Changelog:

[GENERAL] [FIXED] - Updated comments for ~ShadowNodeWrapper() and ~ShadowNodeListWrapper()

Test Plan:

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Software Mansion Partner: Software Mansion Partner labels Jul 10, 2024
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jul 10, 2024
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 21,300,391 -6
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 24,497,490 -6
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 9a1ae97
Branch: main

@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@javache merged this pull request in 778fcec.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 10, 2024
@github-actions
Copy link

This pull request was successfully merged by @tomekzaw in 778fcec.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Software Mansion Partner: Software Mansion Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants