Implement Long Tasks API for PerformanceObserver #45473
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55491870 |
Base commit: c82edec |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55491870 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 16, 2024
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
rubennorte
force-pushed
the
export-D55491870
branch
from
a4418e0 to
d292852
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55491870 |
rubennorte
force-pushed
the
export-D55491870
branch
from
d292852 to
b00e6ab
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Differential Revision: D59820241
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
rubennorte
force-pushed
the
export-D55491870
branch
from
b00e6ab to
462f08c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55491870 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
rubennorte
force-pushed
the
export-D55491870
branch
from
462f08c to
0b0da04
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55491870 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55491870 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
rubennorte
force-pushed
the
export-D55491870
branch
from
0b0da04 to
d1a761a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55491870 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
rubennorte
force-pushed
the
export-D55491870
branch
from
d1a761a to
253407f
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55491870 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55491870 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
rubennorte
force-pushed
the
export-D55491870
branch
from
822f80e to
a1801ee
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55491870 |
rubennorte
force-pushed
the
export-D55491870
branch
from
a1801ee to
2b58c03
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55491870 |
rubennorte
force-pushed
the
export-D55491870
branch
from
2b58c03 to
a4d4b87
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55491870 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
rubennorte
force-pushed
the
export-D55491870
branch
from
a4d4b87 to
ad13000
Compare
Differential Revision: D59820241
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 18, 2024
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55491870 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 18, 2024
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
rubennorte
force-pushed
the
export-D55491870
branch
from
ad13000 to
ff99fd1
Compare
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55491870 |
rubennorte
force-pushed
the
export-D55491870
branch
from
ff99fd1 to
de67637
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
Summary: Pull Request resolved: #45492 Changelog: [internal] When testing the changes in #45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241 fbshipit-source-id: c123920de56336da384ddc484f6ac9d287724301
Contributor
|
This pull request has been merged in 64c4e38. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/).
It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled.
This doesn't include attribution information at the moment.
Changelog: [internal]
Reviewed By: sammy-SC
Differential Revision: D55491870