RN: Enable Hermes Parser in RNTester / CI #46318
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62161923 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62161923 |
yungsters
force-pushed
the
export-D62161923
branch
from
95b062a to
c935d52
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 4, 2024
Summary: Pull Request resolved: facebook#46318 Configures the Metro by default to use the Hermes parser so that React Native can fully leverage all modern Flow language syntax. NOTE: This does not affect `*.ts` and `*.tsx` files which will continue to use Babel. Metro has logic to enforce this regardless of the transform options. Changelog: [General][Changed] - Changed Metro default config to use Hermes parser Differential Revision: D62161923
Summary: Pull Request resolved: facebook#46318 Configures the Metro by default to use the Hermes parser so that React Native can fully leverage all modern Flow language syntax. NOTE: This does not affect `*.ts` and `*.tsx` files which will continue to use Babel. Metro has logic to enforce this regardless of the transform options. Changelog: [General][Changed] - Changed Metro default config to use Hermes parser, enabling the use of advanced Flow syntax in React Native. Differential Revision: D62161923
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62161923 |
yungsters
force-pushed
the
export-D62161923
branch
from
c935d52 to
86de08d
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 4, 2024
Summary: Pull Request resolved: facebook#46318 Configures the Metro by default to use the Hermes parser so that React Native can fully leverage all modern Flow language syntax. NOTE: This does not affect `*.ts` and `*.tsx` files which will continue to use Babel. Metro has logic to enforce this regardless of the transform options. Changelog: [General][Changed] - Changed Metro default config to use Hermes parser, enabling the use of advanced Flow syntax in React Native. Differential Revision: D62161923
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Sep 4, 2024
Summary: Pull Request resolved: facebook#46318 Configures the Metro by default to use the Hermes parser so that React Native can fully leverage all modern Flow language syntax. NOTE: This does not affect `*.ts` and `*.tsx` files which will continue to use Babel. Metro has logic to enforce this regardless of the transform options. Changelog: [General][Changed] - Changed Metro default config to use Hermes parser, enabling the use of advanced Flow syntax in React Native. Differential Revision: D62161923
Contributor
|
This pull request has been merged in 320963c. |
Collaborator
|
This pull request was successfully merged by @yungsters in 320963c When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Configures Metro for RNTester / CI to use the Hermes parser so that React Native can fully leverage all modern Flow language syntax.
Changelog:
[General][Changed] - Changed RNTester's to use Hermes parser
Differential Revision: D62161923