Skip to content

Refactor FabricMountingManager to enable reuse of IntBuffer methods #46600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javache wants to merge 3 commits into from
Closed

Refactor FabricMountingManager to enable reuse of IntBuffer methods #46600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1696205
Remove unused FabricComponents mapping
javache Sep 23, 2024
34a9224
Move ShadowNodePair to Differentiator
javache Sep 23, 2024
7346a21
Refactor FabricMountingManager to enable reuse of IntBuffer methods (…
javache Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/react-native/ReactAndroid/api/ReactAndroid.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2672,11 +2672,6 @@ public final class com/facebook/react/fabric/EmptyReactNativeConfig : com/facebo
public fun getString (Ljava/lang/String;)Ljava/lang/String;
}

public final class com/facebook/react/fabric/FabricComponents {
public static final field INSTANCE Lcom/facebook/react/fabric/FabricComponents;
public static final fun getFabricComponentName (Ljava/lang/String;)Ljava/lang/String;
}

public final class com/facebook/react/fabric/FabricSoLoader {
public static final field INSTANCE Lcom/facebook/react/fabric/FabricSoLoader;
public static final fun staticInit ()V
Expand Down
45 changes: 0 additions & 45 deletions ...ges/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricComponents.kt
View file
Open in desktop

This file was deleted.

12 changes: 3 additions & 9 deletions ...src/main/java/com/facebook/react/fabric/mounting/mountitems/FabricNameComponentMapping.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,7 @@

package com.facebook.react.fabric.mounting.mountitems

/**
* Utility class for Fabric components, this will be removed
*
* TODO T97384889: remove this class when the component names are unified between JS - Android -
* iOS - C++
*/
/** Utility class for Fabric components, this will be removed */
internal object FabricNameComponentMapping {
private val componentNames: Map<String, String> =
mapOf(
Expand All @@ -23,7 +18,7 @@ internal object FabricNameComponentMapping {
"Slider" to "RCTSlider",
"ModalHostView" to "RCTModalHostView",
"Paragraph" to "RCTText",
"Text" to "RCText",
"Text" to "RCTText",
"RawText" to "RCTRawText",
"ActivityIndicatorView" to "AndroidProgressBar",
"ShimmeringView" to "RKShimmeringView",
Expand All @@ -39,7 +34,6 @@ internal object FabricNameComponentMapping {
/** @return the name of component in the Fabric environment */
@JvmStatic
fun getFabricComponentName(componentName: String): String {
val component = componentNames[componentName]
return component ?: componentName
return componentNames[componentName] ?: componentName
}
}
Loading