Parse string unions as StringLiteralUnionTypeAnnotation #46845
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63917685 |
Summary:
You can now define a native module that takes an argument that is a specific string literal:
Like this:
```
export interface Spec extends TurboModule {
+passString: (arg: string) => void;
+passStringLiteral: (arg: 'A String Literal') => void;
}
```
On the native side, this will still generate `string`, but the schema will now store the string literal, and it will be allowed in JS. This should allow more strict flow / typescript types for modules.
This will also allow the compatibility check to fail if the literal changes.
This is a step towards accepting a union of string literals.
Differential Revision: D63872440
Summary: Pull Request resolved: facebook#46845 Previously, the parser was throwing away the values of a string union when storing it in the schema. It would only store the union as ``` { type: 'UnionTypeAnnotation', memberType: 'StringTypeAnnotation' } ``` We now track the string literals through the parser and store them in the schema: ``` { type: 'StringLiteralUnionTypeAnnotation', types: [ { type: 'StringLiteralTypeAnnotation' value: 'light' }, { type: 'StringLiteralTypeAnnotation' value: 'dark' }, ], } ``` We aren't changing the generators, those still just output "string". They could eventually be made smarter. The value of this is that the compat checker can now error when the union changes. Changelog: [Internal] Differential Revision: D63917685
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63917685 |
elicwhite
force-pushed
the
export-D63917685
branch
from
0a27684 to
a365513
Compare
elicwhite
added a commit
to elicwhite/react-native
that referenced
this pull request
Oct 7, 2024
Summary:
Previously, the parser was throwing away the values of a string union when storing it in the schema. It would only store the union as
```
{
type: 'UnionTypeAnnotation',
memberType: 'StringTypeAnnotation'
}
```
We now track the string literals through the parser and store them in the schema:
```
{
type: 'StringLiteralUnionTypeAnnotation',
types: [
{
type: 'StringLiteralTypeAnnotation'
value: 'light'
},
{
type: 'StringLiteralTypeAnnotation'
value: 'dark'
},
],
}
```
We aren't changing the generators, those still just output "string". They could eventually be made smarter.
The value of this is that the compat checker can now error when the union changes.
Changelog: [Internal]
Reviewed By: yungsters
Differential Revision: D63917685
Contributor
|
This pull request has been merged in a669de1. |
Collaborator
|
This pull request was successfully merged by @elicwhite in a669de1 When will my fix make it into a release? | How to file a pick request? |
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, the parser was throwing away the values of a string union when storing it in the schema. It would only store the union as
We now track the string literals through the parser and store them in the schema:
We aren't changing the generators, those still just output "string". They could eventually be made smarter.
The value of this is that the compat checker can now error when the union changes.
Changelog: [Internal]
Differential Revision: D63917685