Align earlyjs c++ stack trace parsing with js #46894

RSNara · 2024-10-08T17:50:12Z

Summary:
This diff re-implements js error stack trace parsing in c++.

Details:

I migrated stacktrace-parser
I migrated parseHermesStack.js

I also migrated all their tests to c++:

Changelog: [Internal]

Reviewed By: javache, NickGerleman

Differential Revision: D63659013

facebook-github-bot · 2024-10-08T17:50:20Z

This pull request was exported from Phabricator. Differential Revision: D63659013

facebook-github-bot · 2024-10-08T17:53:42Z

This pull request was exported from Phabricator. Differential Revision: D63659013

facebook-github-bot · 2024-10-08T18:05:36Z

This pull request was exported from Phabricator. Differential Revision: D63659013

facebook-github-bot · 2024-10-08T18:11:31Z

This pull request was exported from Phabricator. Differential Revision: D63659013

facebook-github-bot · 2024-10-08T18:11:43Z

This pull request was exported from Phabricator. Differential Revision: D63659013

facebook-github-bot · 2024-10-08T21:14:41Z

This pull request was exported from Phabricator. Differential Revision: D63659013

facebook-github-bot · 2024-10-09T13:54:29Z

This pull request was exported from Phabricator. Differential Revision: D63659013

facebook-github-bot · 2024-10-09T15:37:44Z

This pull request was exported from Phabricator. Differential Revision: D63659013

facebook-github-bot · 2024-10-09T20:06:01Z

This pull request was exported from Phabricator. Differential Revision: D63659013

facebook-github-bot · 2024-10-09T20:08:37Z

This pull request was exported from Phabricator. Differential Revision: D63659013

facebook-github-bot · 2024-10-09T20:25:21Z

This pull request was exported from Phabricator. Differential Revision: D63659013

Summary: This diff re-implements [js error stack trace parsing](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/parseErrorStack.js#L41-L57) in c++. Details: - I migrated [stacktrace-parser](https://github.com/errwischt/stacktrace-parser/blob/ad379de5e5ac056012bbeb12923cf502aefe4710/src/stack-trace-parser.js#L7) - I migrated [parseHermesStack.js](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/parseHermesStack.js#L82) I also migrated all their tests to c++: - [stacktrace-parser tests](https://github.com/errwischt/stacktrace-parser/blob/ad379de5e5ac056012bbeb12923cf502aefe4710/test/stack-trace-parser.spec.js#L5) - [parseHermesStack tests](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/__tests__/parseHermesStack-test.js#L16) Changelog: [Internal] Reviewed By: javache, NickGerleman Differential Revision: D63659013

facebook-github-bot · 2024-10-09T20:41:43Z

This pull request was exported from Phabricator. Differential Revision: D63659013

Summary: This diff re-implements [js error stack trace parsing](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/parseErrorStack.js#L41-L57) in c++. Details: - I migrated [stacktrace-parser](https://github.com/errwischt/stacktrace-parser/blob/ad379de5e5ac056012bbeb12923cf502aefe4710/src/stack-trace-parser.js#L7) - I migrated [parseHermesStack.js](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/parseHermesStack.js#L82) I also migrated all their tests to c++: - [stacktrace-parser tests](https://github.com/errwischt/stacktrace-parser/blob/ad379de5e5ac056012bbeb12923cf502aefe4710/test/stack-trace-parser.spec.js#L5) - [parseHermesStack tests](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/__tests__/parseHermesStack-test.js#L16) Changelog: [Internal] Reviewed By: javache, NickGerleman Differential Revision: D63659013

facebook-github-bot · 2024-10-09T21:50:16Z

This pull request was exported from Phabricator. Differential Revision: D63659013

facebook-github-bot · 2024-10-09T22:38:40Z

This pull request was exported from Phabricator. Differential Revision: D63659013

facebook-github-bot · 2024-10-09T23:06:04Z

This pull request was exported from Phabricator. Differential Revision: D63659013

facebook-github-bot · 2024-10-09T23:16:01Z

This pull request was exported from Phabricator. Differential Revision: D63659013

Summary: This diff re-implements [js error stack trace parsing](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/parseErrorStack.js#L41-L57) in c++. Details: - I migrated [stacktrace-parser](https://github.com/errwischt/stacktrace-parser/blob/ad379de5e5ac056012bbeb12923cf502aefe4710/src/stack-trace-parser.js#L7) - I migrated [parseHermesStack.js](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/parseHermesStack.js#L82) I also migrated all their tests to c++: - [stacktrace-parser tests](https://github.com/errwischt/stacktrace-parser/blob/ad379de5e5ac056012bbeb12923cf502aefe4710/test/stack-trace-parser.spec.js#L5) - [parseHermesStack tests](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/__tests__/parseHermesStack-test.js#L16) Changelog: [Internal] Reviewed By: javache, NickGerleman Differential Revision: D63659013

facebook-github-bot · 2024-10-09T23:24:00Z

This pull request was exported from Phabricator. Differential Revision: D63659013

Summary: This diff re-implements [js error stack trace parsing](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/parseErrorStack.js#L41-L57) in c++. Details: - I migrated [stacktrace-parser](https://github.com/errwischt/stacktrace-parser/blob/ad379de5e5ac056012bbeb12923cf502aefe4710/src/stack-trace-parser.js#L7) - I migrated [parseHermesStack.js](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/parseHermesStack.js#L82) I also migrated all their tests to c++: - [stacktrace-parser tests](https://github.com/errwischt/stacktrace-parser/blob/ad379de5e5ac056012bbeb12923cf502aefe4710/test/stack-trace-parser.spec.js#L5) - [parseHermesStack tests](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/__tests__/parseHermesStack-test.js#L16) Changelog: [Internal] Reviewed By: javache, NickGerleman Differential Revision: D63659013

facebook-github-bot · 2024-10-10T00:13:32Z

This pull request was exported from Phabricator. Differential Revision: D63659013

Summary: This diff re-implements [js error stack trace parsing](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/parseErrorStack.js#L41-L57) in c++. Details: - I migrated [stacktrace-parser](https://github.com/errwischt/stacktrace-parser/blob/ad379de5e5ac056012bbeb12923cf502aefe4710/src/stack-trace-parser.js#L7) - I migrated [parseHermesStack.js](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/parseHermesStack.js#L82) I also migrated all their tests to c++: - [stacktrace-parser tests](https://github.com/errwischt/stacktrace-parser/blob/ad379de5e5ac056012bbeb12923cf502aefe4710/test/stack-trace-parser.spec.js#L5) - [parseHermesStack tests](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/__tests__/parseHermesStack-test.js#L16) Changelog: [Internal] Reviewed By: javache, NickGerleman Differential Revision: D63659013

facebook-github-bot · 2024-10-10T18:35:47Z

This pull request was exported from Phabricator. Differential Revision: D63659013

Summary: For the js error handling pipeline, the javascript data structure looks like [this](https://www.internalfb.com/code/fbsource/[6181b57f4ba3619f58056bcec65382650d6ff59a]/xplat/js/react-native-github/packages/react-native/src/private/specs/modules/NativeExceptionsManager.js?lines=17-35): ``` export type StackFrame = {| column: ?number, file: ?string, lineNumber: ?number, methodName: string, collapse?: boolean, |}; export type ExceptionData = { message: string, originalMessage: ?string, name: ?string, componentStack: ?string, stack: Array<StackFrame>, id: number, isFatal: boolean, // flowlint-next-line unclear-type:off extraData?: Object, ... }; ``` So, I made the c++ data structure look similar ``` struct ParsedError { struct StackFrame { std::optional<std::string> file; std::string methodName; std::optional<int> lineNumber; std::optional<int> column; }; std::string message; std::optional<std::string> originalMessage; std::optional<std::string> name; std::optional<std::string> componentStack; std::vector<StackFrame> stack; int id; bool isFatal; jsi::Object extraData; }; ``` Notes: * [parseErrorStack](https://fburl.com/code/e27q9gkc) doesn't actually generate a collapse property on the error object. So, I omitted it from the c++. * ExceptionsManager [always provides an extraData field](https://fburl.com/code/2bvcsxac). So, I made it required. * In C++, I just stored extraData as a jsi::Object. I wanted the freedom to store arbitrary key/value pairs. But, I also didn't want to use folly::dynamic. Changelog: [Internal] Reviewed By: alanleedev Differential Revision: D63929580

Summary: This diff re-implements [js error stack trace parsing](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/parseErrorStack.js#L41-L57) in c++. Details: - I migrated [stacktrace-parser](https://github.com/errwischt/stacktrace-parser/blob/ad379de5e5ac056012bbeb12923cf502aefe4710/src/stack-trace-parser.js#L7) - I migrated [parseHermesStack.js](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/parseHermesStack.js#L82) I also migrated all their tests to c++: - [stacktrace-parser tests](https://github.com/errwischt/stacktrace-parser/blob/ad379de5e5ac056012bbeb12923cf502aefe4710/test/stack-trace-parser.spec.js#L5) - [parseHermesStack tests](https://github.com/facebook/react-native/blob/86cac6836502aaeb5c894bff6427e837c52c09e0/packages/react-native/Libraries/Core/Devtools/__tests__/parseHermesStack-test.js#L16) Changelog: [Internal] Reviewed By: javache, NickGerleman Differential Revision: D63659013

facebook-github-bot · 2024-10-10T18:36:55Z

This pull request was exported from Phabricator. Differential Revision: D63659013

facebook-github-bot · 2024-10-10T23:07:41Z

This pull request has been merged in 934af0c.

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2024

facebook-github-bot added fb-exported p: Facebook Partner: Facebook Partner labels Oct 8, 2024

RSNara force-pushed the export-D63659013 branch from 33a5b18 to bc4f84a Compare October 8, 2024 17:53

RSNara force-pushed the export-D63659013 branch from bc4f84a to 6296810 Compare October 8, 2024 18:05

RSNara force-pushed the export-D63659013 branch from 6296810 to 9a89124 Compare October 8, 2024 18:11

RSNara force-pushed the export-D63659013 branch from 9a89124 to af2f5d3 Compare October 8, 2024 18:11

RSNara force-pushed the export-D63659013 branch from af2f5d3 to ee29f59 Compare October 8, 2024 21:14

RSNara force-pushed the export-D63659013 branch from ee29f59 to 8d7df1c Compare October 9, 2024 13:54

RSNara force-pushed the export-D63659013 branch from 8d7df1c to 040211a Compare October 9, 2024 15:37

RSNara force-pushed the export-D63659013 branch from 040211a to ffdd2d1 Compare October 9, 2024 20:05

RSNara force-pushed the export-D63659013 branch from ffdd2d1 to 13da136 Compare October 9, 2024 20:08

RSNara force-pushed the export-D63659013 branch from 13da136 to 2c0125e Compare October 9, 2024 20:25

RSNara force-pushed the export-D63659013 branch from 2c0125e to 2653774 Compare October 9, 2024 20:41

RSNara force-pushed the export-D63659013 branch from 2653774 to 8d15569 Compare October 9, 2024 21:12

RSNara force-pushed the export-D63659013 branch from da194e3 to 0579cd3 Compare October 9, 2024 21:49

RSNara force-pushed the export-D63659013 branch from 0579cd3 to 4673d8f Compare October 9, 2024 22:38

RSNara force-pushed the export-D63659013 branch from 4673d8f to 514ba23 Compare October 9, 2024 23:06

RSNara force-pushed the export-D63659013 branch from 514ba23 to 25d7534 Compare October 9, 2024 23:15

RSNara force-pushed the export-D63659013 branch from 25d7534 to 15beaa6 Compare October 9, 2024 23:23

RSNara force-pushed the export-D63659013 branch from 15beaa6 to 8597ea5 Compare October 10, 2024 00:13

RSNara force-pushed the export-D63659013 branch from 8597ea5 to ff868ce Compare October 10, 2024 18:35

RSNara added 2 commits October 10, 2024 11:36

RSNara force-pushed the export-D63659013 branch from ff868ce to 7ee42cd Compare October 10, 2024 18:36

facebook-github-bot closed this in 934af0c Oct 10, 2024

facebook-github-bot added the Merged This PR has been merged. label Oct 10, 2024

This was referenced Nov 12, 2024

Integrate RN Nightly 10/20 microsoft/react-native-windows#14092

Merged

Integrate RN Nightly 10/15 microsoft/react-native-windows#14107

Merged

Align earlyjs c++ stack trace parsing with js #46894

Align earlyjs c++ stack trace parsing with js #46894

Uh oh!

Conversation

RSNara commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 10, 2024

Uh oh!

facebook-github-bot commented Oct 10, 2024

Uh oh!

facebook-github-bot commented Oct 10, 2024

Uh oh!

facebook-github-bot commented Oct 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants