Unify feature flags for event loop #46953
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64175216 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64175216 |
rubennorte
force-pushed
the
export-D64175216
branch
from
b3c9fa2 to
590926b
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 10, 2024
Summary: Pull Request resolved: facebook#46953 Changelog: [internal] This unifies all the feature flags that control the new event loop on RN. Before, we'd have granular flags for different aspects of it. With this diff, we enable the event loop by default with bridgeless, and we introduce a new flag to explicitly disable it in that case if necessary. When we're ready to clean up this opt-out, we just need to remove the `&& !ReactNativeFeatureFlags::disableEventLoopOnBridgeless()` conditions. Reviewed By: javache Differential Revision: D64175216
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64175216 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 11, 2024
Summary: Pull Request resolved: facebook#46953 Changelog: [internal] This unifies all the feature flags that control the new event loop on RN. Before, we'd have granular flags for different aspects of it. With this diff, we enable the event loop by default with bridgeless, and we introduce a new flag to explicitly disable it in that case if necessary. When we're ready to clean up this opt-out, we just need to remove the `&& !ReactNativeFeatureFlags::disableEventLoopOnBridgeless()` conditions. Reviewed By: javache Differential Revision: D64175216
rubennorte
force-pushed
the
export-D64175216
branch
from
590926b to
e282e88
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64175216 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 11, 2024
Summary: Pull Request resolved: facebook#46953 Changelog: [internal] This unifies all the feature flags that control the new event loop on RN. Before, we'd have granular flags for different aspects of it. With this diff, we enable the event loop by default with bridgeless, and we introduce a new flag to explicitly disable it in that case if necessary. When we're ready to clean up this opt-out, we just need to remove the `&& !ReactNativeFeatureFlags::disableEventLoopOnBridgeless()` conditions. Reviewed By: javache Differential Revision: D64175216
rubennorte
force-pushed
the
export-D64175216
branch
from
e282e88 to
6d864c6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64175216 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 14, 2024
Summary: Pull Request resolved: facebook#46953 Changelog: [internal] This unifies all the feature flags that control the new event loop on RN. Before, we'd have granular flags for different aspects of it. With this diff, we enable the event loop by default with bridgeless, and we introduce a new flag to explicitly disable it in that case if necessary. When we're ready to clean up this opt-out, we just need to remove the `&& !ReactNativeFeatureFlags::disableEventLoopOnBridgeless()` conditions. Reviewed By: javache Differential Revision: D64175216
rubennorte
force-pushed
the
export-D64175216
branch
from
6d864c6 to
1f3539f
Compare
…nabled Differential Revision: D64234056
Summary: Pull Request resolved: facebook#46953 Changelog: [internal] This unifies all the feature flags that control the new event loop on RN. Before, we'd have granular flags for different aspects of it. With this diff, we enable the event loop by default with bridgeless, and we introduce a new flag to explicitly disable it in that case if necessary. When we're ready to clean up this opt-out, we just need to remove the `&& !ReactNativeFeatureFlags::disableEventLoopOnBridgeless()` conditions. Reviewed By: javache Differential Revision: D64175216
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64175216 |
rubennorte
force-pushed
the
export-D64175216
branch
from
1f3539f to
7bf810a
Compare
Contributor
|
This pull request has been merged in 9e5b6e8. |
Contributor
|
This pull request has been reverted by 85f1d9a. |
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This unifies all the feature flags that control the new event loop on RN. Before, we'd have granular flags for different aspects of it. With this diff, we enable the event loop by default with bridgeless, and we introduce a new flag to explicitly disable it in that case if necessary.
Differential Revision: D64175216