[iOS] Add png extension only if file exist when load local image#46971
Closed
zhongwuzw wants to merge 1 commit intofacebook:mainfrom
Closed
[iOS] Add png extension only if file exist when load local image#46971zhongwuzw wants to merge 1 commit intofacebook:mainfrom
zhongwuzw wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
@zhongwuzw news? 🙏 |
Contributor
Author
Hi, let me try to find someone to review. |
Contributor
Author
|
@fbp93 Hi, sorry for the delayed response. I contacted the RN team, and this week they’re busy with the 0.76 release and also have a team summit, so things will be slower than usual. |
ok thanks 👍 No worries, in the meanwhile I'm creating a patch with the fix and I'm using that one |
Contributor
|
I'm a bit confused. This code is 5 years old, how come it stopped working recently? That said, the fix looks ok. It seems reasonable to add the extension only if the file exists. |
cipolleschi
reviewed
Oct 28, 2024
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
See my comment above.
Contributor
Author
|
@cipolleschi Hi, #37232 leads to the issue, we changes the sandbox file loading mechanism , and uses URLRequest to load the file image instead. So back to this PR, seems it's also reasonable to check whether file exist before add png extension. :) |
cipolleschi
approved these changes
Oct 31, 2024
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for digging into the issue and for working on the fix.
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 44f2a08. |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 23, 2025
Summary: We have a report from OSS where Images are not displayed properly in case they are saved on disk with no extension. We previously had a fix attempt iwith [this pr](facebook#46971), but this was breaking some internal apps. This second attempt should work for both cases. ## Changelog: [iOS][Fixed] - Load images even when the extension is implicit Differential Revision: D68555813
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
Summary: Pull Request resolved: #48888 We have a report from OSS where Images are not displayed properly in case they are saved on disk with no extension. We previously had a fix attempt iwith [this pr](#46971), but this was breaking some internal apps. This second attempt should work for both cases. ## Changelog: [iOS][Fixed] - Load images even when the extension is implicit Reviewed By: cortinico Differential Revision: D68555813 fbshipit-source-id: bc25970aafe3e6e5284163b663d36e00b3df3d82
fabriziocucci
pushed a commit
that referenced
this pull request
Jan 27, 2025
Summary: Pull Request resolved: #48888 We have a report from OSS where Images are not displayed properly in case they are saved on disk with no extension. We previously had a fix attempt iwith [this pr](#46971), but this was breaking some internal apps. This second attempt should work for both cases. ## Changelog: [iOS][Fixed] - Load images even when the extension is implicit Reviewed By: cortinico Differential Revision: D68555813 fbshipit-source-id: bc25970aafe3e6e5284163b663d36e00b3df3d82
cortinico
pushed a commit
that referenced
this pull request
Feb 5, 2025
Summary: Pull Request resolved: #48888 We have a report from OSS where Images are not displayed properly in case they are saved on disk with no extension. We previously had a fix attempt iwith [this pr](#46971), but this was breaking some internal apps. This second attempt should work for both cases. ## Changelog: [iOS][Fixed] - Load images even when the extension is implicit Reviewed By: cortinico Differential Revision: D68555813 fbshipit-source-id: bc25970aafe3e6e5284163b663d36e00b3df3d82
cipolleschi
added a commit
that referenced
this pull request
Feb 6, 2025
Summary: Pull Request resolved: #48888 We have a report from OSS where Images are not displayed properly in case they are saved on disk with no extension. We previously had a fix attempt iwith [this pr](#46971), but this was breaking some internal apps. This second attempt should work for both cases. ## Changelog: [iOS][Fixed] - Load images even when the extension is implicit Reviewed By: cortinico Differential Revision: D68555813 fbshipit-source-id: bc25970aafe3e6e5284163b663d36e00b3df3d82
robhogan
pushed a commit
that referenced
this pull request
Feb 11, 2025
Summary: Pull Request resolved: #48888 We have a report from OSS where Images are not displayed properly in case they are saved on disk with no extension. We previously had a fix attempt iwith [this pr](#46971), but this was breaking some internal apps. This second attempt should work for both cases. ## Changelog: [iOS][Fixed] - Load images even when the extension is implicit Reviewed By: cortinico Differential Revision: D68555813 fbshipit-source-id: bc25970aafe3e6e5284163b663d36e00b3df3d82
linhandev
pushed a commit
to linhandev/react-native-core
that referenced
this pull request
Jun 26, 2025
Summary: Pull Request resolved: facebook/react-native#48888 We have a report from OSS where Images are not displayed properly in case they are saved on disk with no extension. We previously had a fix attempt iwith [this pr](facebook/react-native#46971), but this was breaking some internal apps. This second attempt should work for both cases. ## Changelog: [iOS][Fixed] - Load images even when the extension is implicit Reviewed By: cortinico Differential Revision: D68555813 fbshipit-source-id: bc25970aafe3e6e5284163b663d36e00b3df3d82
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
Summary: Pull Request resolved: facebook#48888 We have a report from OSS where Images are not displayed properly in case they are saved on disk with no extension. We previously had a fix attempt iwith [this pr](facebook#46971), but this was breaking some internal apps. This second attempt should work for both cases. ## Changelog: [iOS][Fixed] - Load images even when the extension is implicit Reviewed By: cortinico Differential Revision: D68555813 fbshipit-source-id: bc25970aafe3e6e5284163b663d36e00b3df3d82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
FIxes #46870.
To avoid many breaking changes, I modified the logic to add the PNG extension only if the file exists.
Changelog:
[IOS] [FIXED] - Add png extension only if file exist when load local image
Test Plan:
Demo in #46870 .