RN: Fix lint/sort-imports Errors
#47109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64569485 |
Summary: Pull Request resolved: facebook#47109 Fixes the `lint/sort-imports` errors that are now surfaced after fixing the lint configuration. For a couple files, I added lint suppressions instead because the unsorted import ordering is important due to interleaved calls with side effects. Changelog: [Internal] Differential Revision: D64569485
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64569485 |
yungsters
force-pushed
the
export-D64569485
branch
from
6af6ecb to
ba9d2fb
Compare
Contributor
|
This pull request has been merged in c9ea055. |
Collaborator
|
This pull request was successfully merged by @yungsters in c9ea055 When will my fix make it into a release? | How to file a pick request? |
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes the
lint/sort-importserrors that are now surfaced after fixing the lint configuration.For a couple files, I added lint suppressions instead because the unsorted import ordering is important due to interleaved calls with side effects.
Changelog:
[Internal]
Differential Revision: D64569485