Closed
Conversation
6 tasks
Contributor
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Collaborator
|
This pull request was successfully merged by @s77rt in e8f8ee3 When will my fix make it into a release? | How to file a pick request? |
Contributor
Author
|
@javache @NickGerleman Thank you! |
49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When the app goes into background the frame callback is ignored by setting the
mShouldStopflag totruereact-native/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/FabricEventDispatcher.java
Line 174 in 3111473
However this flag is never reset even after the app is back on foreground. This made the
AndroidEventBeatnot ticking in as much as expected causing events not being dispatched in time. In our case theonLayoutwas not being dispatched unless we tap on screen invoking a manual tick.Changelog:
[ANDROID] [FIXED] - Fix Frame Callback not being called after Host Resume
Test Plan:
__android_log_print(ANDROID_LOG_DEBUG, "s77rt", "AndroidEventBeat::tick");inpackages/react-native/ReactAndroid/src/main/jni/react/fabric/AndroidEventBeat.cpp(tick method)AndroidEventBeat::tickis logged for every frameAndroidEventBeat::tickis loggedAndroidEventBeat::tickis logged for every frameScreen.Recording.2024-10-28.at.9.02.05.PM-1.mov
Screen.Recording.2024-10-28.at.9.02.54.PM-1.mov
Screen.Recording.2024-10-28.at.9.25.54.PM-1.mov
Screen.Recording.2024-10-28.at.9.29.45.PM-1.mov