fix(iOS): unify prefetchImageWithMetadata's signature in JS and ObjC land#47532
Closed
TheRogue76 wants to merge 2 commits intofacebook:mainfrom
TheRogue76:main
Closed
fix(iOS): unify prefetchImageWithMetadata's signature in JS and ObjC land#47532TheRogue76 wants to merge 2 commits intofacebook:mainfrom TheRogue76:main
TheRogue76 wants to merge 2 commits intofacebook:mainfrom
TheRogue76:main
Conversation
facebook-github-bot
added
CLA Signed
cipolleschi
approved these changes
Nov 11, 2024
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
thanks for this fix!
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
No idea how i managed to kill the poor CI for it to take 165 minutes. @cipolleschi Did it say what had gone wrong? |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 18, 2024
…nal (facebook#47532) Summary: in `prefetchImageWithMetadata`'s implementation in ObjC, the method's `queryRootName` is treated as being nullable. The image spec for it in JS (and the Codegened ObjC header that gets built on top of it) treat the field as not nullable. This change makes the field nullable in the spec to match up what we have in the implementation. I also noticed that the method is not defined in the [Image props](https://reactnative.dev/docs/image) on the RN website, so perhaps we should add this there as well. ## Changelog: [IOS] [CHANGED] - make `prefetchImageWithMetadata`'s `queryRootName` nullable in the spec Pull Request resolved: facebook#47532 Test Plan: yarn test: <img width="1576" alt="Screenshot 2024-11-09 at 00 36 30" src="https://github.com/user-attachments/assets/4162ff79-1388-4f6f-9576-256fd9011fcf"> It has no iOS specific tests, so nothing to run on that side Differential Revision: D65761208
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 18, 2024
…land (facebook#47532) Summary: in `prefetchImageWithMetadata`'s implementation in ObjC, the method's `queryRootName` is treated as being nullable. The image spec for it in JS (and the Codegened ObjC header that gets built on top of it) treat the field as not nullable. This change makes the field nullable in the spec to match up what we have in the implementation. I also noticed that the method is not defined in the [Image props](https://reactnative.dev/docs/image) on the RN website, so perhaps we should add this there as well. ## Changelog: [IOS] [CHANGED] - make `prefetchImageWithMetadata`'s `queryRootName` nullable in the spec Pull Request resolved: facebook#47532 Test Plan: yarn test: <img width="1576" alt="Screenshot 2024-11-09 at 00 36 30" src="https://github.com/user-attachments/assets/4162ff79-1388-4f6f-9576-256fd9011fcf"> It has no iOS specific tests, so nothing to run on that side Differential Revision: D66093745 Pulled By: cipolleschi
Contributor
|
@cipolleschi merged this pull request in 4dd60ac. |
Collaborator
|
This pull request was successfully merged by @TheRogue76 in 4dd60ac When will my fix make it into a release? | How to file a pick request? |
rezkiy37
added a commit
to rezkiy37/react-native
that referenced
this pull request
Nov 18, 2024
…nd ObjC land (facebook#47532)" This reverts commit 4dd60ac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
in
prefetchImageWithMetadata's implementation in ObjC, the method'squeryRootNameis treated as being nullable. The image spec for it in JS (and the Codegened ObjC header that gets built on top of it) treat the field as not nullable. This change makes the field nullable in the spec to match up what we have in the implementation.I also noticed that the method is not defined in the Image props on the RN website, so perhaps we should add this there as well.
Changelog:
[IOS] [CHANGED] - make
prefetchImageWithMetadata'squeryRootNamenullable in the specTest Plan:
yarn test:
It has no iOS specific tests, so nothing to run on that side