Share TextLayoutManager.h across all platforms #48210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

christophpurrer wants to merge 1 commit into facebook:main from christophpurrer:export-D67064488

Contributor

christophpurrer commented Dec 11, 2024

Summary:
[Changelog] [Internal] - Share TextLayoutManager.h across all platforms

The goal of this change is to enable to share TextLayoutManager.h across all platforms, the same we do for:

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Differential Revision: D67064488

facebook-github-bot added CLA Signed p: Facebook Partner labels

Contributor

facebook-github-bot commented Dec 11, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Dec 11, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

christophpurrer force-pushed the export-D67064488 branch from 0773a8f to b63572b Compare

December 11, 2024 02:39

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Share TextLayoutManager.h across all platforms (facebook#48210)

b63572b

Summary:
Pull Request resolved: facebook#48210

[Changelog] [Internal] - Share TextLayoutManager.h across all platforms

The goal of this change is to enable to share `TextLayoutManager.h` across all platforms, the same we do for:

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Differential Revision: D67064488

Contributor

facebook-github-bot commented Dec 11, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Share TextLayoutManager.h across all platforms (facebook#48210)

5cd9b10

Summary:
Pull Request resolved: facebook#48210

[Changelog] [Internal] - Share TextLayoutManager.h across all platforms

The goal of this change is to enable to share `TextLayoutManager.h` across all platforms, the same we do for:

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Differential Revision: D67064488

christophpurrer force-pushed the export-D67064488 branch from b63572b to 5cd9b10 Compare

December 11, 2024 02:51

Contributor

facebook-github-bot commented Dec 11, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Share TextLayoutManager.h across all platforms (facebook#48210)

6c2fdd1

Summary:
Pull Request resolved: facebook#48210

[Changelog] [Internal] - Share TextLayoutManager.h across all platforms

The goal of this change is to enable to share `TextLayoutManager.h` across all platforms, the same we do for:

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Differential Revision: D67064488

christophpurrer force-pushed the export-D67064488 branch from 5cd9b10 to 6c2fdd1 Compare

December 11, 2024 03:22

Contributor

facebook-github-bot commented Dec 11, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Share TextLayoutManager.h across all platforms (facebook#48210)

ace6ce6

Summary:
Pull Request resolved: facebook#48210

[Changelog] [Internal] - Share TextLayoutManager.h across all platforms

The goal of this change is to enable to share `TextLayoutManager.h` across all platforms, the same we do for:

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Differential Revision: D67064488

christophpurrer force-pushed the export-D67064488 branch from 6c2fdd1 to ace6ce6 Compare

December 11, 2024 04:38

Contributor

facebook-github-bot commented Dec 11, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Share TextLayoutManager.h across all platforms (facebook#48210)

f469832

Summary:
Pull Request resolved: facebook#48210

[Changelog] [Internal] - Share TextLayoutManager.h across all platforms

The goal of this change is to enable to share `TextLayoutManager.h` across all platforms, the same we do for:

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Differential Revision: D67064488

christophpurrer force-pushed the export-D67064488 branch from ace6ce6 to f469832 Compare

December 11, 2024 06:46

Contributor

facebook-github-bot commented Dec 11, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Share TextLayoutManager.h across all platforms (facebook#48210)

8b6c65a

Summary:
Pull Request resolved: facebook#48210

[Changelog] [Internal] - Share TextLayoutManager.h across all platforms

The goal of this change is to enable to share `TextLayoutManager.h` across all platforms, the same we do for:

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Differential Revision: D67064488

christophpurrer force-pushed the export-D67064488 branch from f469832 to 8b6c65a Compare

December 11, 2024 17:24

Contributor

facebook-github-bot commented Dec 11, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Share TextLayoutManager.h across all platforms (facebook#48210)

9a2cb0b

Summary:
Pull Request resolved: facebook#48210

[Changelog] [Internal] - Share TextLayoutManager.h across all platforms

The goal of this change is to enable to share `TextLayoutManager.h` across all platforms, the same we do for:

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Differential Revision: D67064488

christophpurrer force-pushed the export-D67064488 branch from 8b6c65a to 9a2cb0b Compare

December 11, 2024 17:41

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Share TextLayoutManager.h across all platforms (facebook#48210)

9ef8a4d

Summary:
Pull Request resolved: facebook#48210

[Changelog] [Internal] - Share TextLayoutManager.h across all platforms

The goal of this change is to enable to share `TextLayoutManager.h` across all platforms, the same we do for:

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Reviewed By: philIip

Differential Revision: D67064488

christophpurrer force-pushed the export-D67064488 branch from 9a2cb0b to 9ef8a4d Compare

December 12, 2024 05:30

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

1 similar comment

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

christophpurrer force-pushed the export-D67064488 branch from f5f08b8 to 00aad08 Compare

December 12, 2024 21:39

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

christophpurrer force-pushed the export-D67064488 branch from 00aad08 to 6e395b8 Compare

December 12, 2024 23:51

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Share TextLayoutManager.h across all platforms (facebook#48210)

6e395b8

Summary:
Pull Request resolved: facebook#48210

[Changelog] [Internal] - Share TextLayoutManager.h across all platforms

The goal of this change is to enable to share `TextLayoutManager.h` across all platforms, the same we do for:

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Reviewed By: philIip

Differential Revision: D67064488

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Share TextLayoutManager.h across all platforms (facebook#48210)

5d9e36a

Summary:
Pull Request resolved: facebook#48210

[Changelog] [Internal] - Share TextLayoutManager.h across all platforms

The goal of this change is to enable to share `TextLayoutManager.h` across all platforms, the same we do for:

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Reviewed By: philIip

Differential Revision: D67064488

christophpurrer force-pushed the export-D67064488 branch from 6e395b8 to 5d9e36a Compare

December 12, 2024 23:57

Contributor

facebook-github-bot commented Dec 13, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Share TextLayoutManager.h across all platforms (facebook#48210)

8353ee9

Summary:
Pull Request resolved: facebook#48210

[Changelog] [Internal] - Share TextLayoutManager.h across all platforms

The goal of this change is to enable to share `TextLayoutManager.h` across all platforms, the same we do for:

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Reviewed By: philIip

Differential Revision: D67064488

christophpurrer force-pushed the export-D67064488 branch from 5d9e36a to 8353ee9 Compare

December 13, 2024 01:27

Contributor

facebook-github-bot commented Dec 13, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Share TextLayoutManager.h across all platforms (facebook#48210)

c4554ef

Summary:
Pull Request resolved: facebook#48210

[Changelog] [Internal] - Share TextLayoutManager.h across all platforms

The goal of this change is to enable to share `TextLayoutManager.h` across all platforms, the same we do for:

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Reviewed By: philIip

Differential Revision: D67064488

christophpurrer force-pushed the export-D67064488 branch from 8353ee9 to c4554ef Compare

December 13, 2024 02:18

Contributor

facebook-github-bot commented Dec 13, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Share TextLayoutManager.h across all platforms (facebook#48210)

82e2013

Summary:
Pull Request resolved: facebook#48210

[Changelog] [Internal] - Share TextLayoutManager.h across all platforms

The goal of this change is to enable to share `TextLayoutManager.h` across all platforms, the same we do for:

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Reviewed By: philIip

Differential Revision: D67064488

christophpurrer force-pushed the export-D67064488 branch from c4554ef to 82e2013 Compare

December 13, 2024 02:43

Contributor

facebook-github-bot commented Dec 13, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Share TextLayoutManager.h across all platforms (facebook#48210)

5dc026e

Summary:
Pull Request resolved: facebook#48210

[Changelog] [Internal] - Share TextLayoutManager.h across all platforms

The goal of this change is to enable to share `TextLayoutManager.h` across all platforms, the same we do for:

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Reviewed By: philIip

Differential Revision: D67064488

christophpurrer force-pushed the export-D67064488 branch from 82e2013 to 5dc026e Compare

December 13, 2024 04:22

Contributor

facebook-github-bot commented Dec 13, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

christophpurrer force-pushed the export-D67064488 branch from 5dc026e to f26eeca Compare

December 13, 2024 18:23

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Share TextLayoutManager.h across all platforms (facebook#48210)

f26eeca

Summary:
Pull Request resolved: facebook#48210

[Changelog] [Internal] - Share TextLayoutManager.h across all platforms

The goal of this change is to enable to share `TextLayoutManager.h` across all platforms, the same we do for:

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Reviewed By: philIip

Differential Revision: D67064488


          Share TextLayoutManager.h across all platforms (facebook#48210)

0c82239

Summary:
Pull Request resolved: facebook#48210

[Changelog] [Internal] - Share TextLayoutManager.h across all platforms

The goal of this change is to enable to share `TextLayoutManager.h` across all platforms, the same we do for:

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageManager.h

Reviewed By: philIip

Differential Revision: D67064488

Contributor

facebook-github-bot commented Dec 13, 2024

This pull request was exported from Phabricator. Differential Revision: D67064488

christophpurrer force-pushed the export-D67064488 branch from f26eeca to 0c82239 Compare

December 13, 2024 18:49

facebook-github-bot closed this in

ae90dd3

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Dec 14, 2024

This pull request has been merged in ae90dd3.

Collaborator

react-native-bot commented Dec 14, 2024

This pull request was successfully merged by @christophpurrer in ae90dd3

^{When will my fix make it into a release? | How to file a pick request?}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner