Add logging in ReactInstanceManager.onHostPause when activity is incorrectly null #48226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67123351 |
mlord93
pushed a commit
to mlord93/react-native
that referenced
this pull request
Dec 12, 2024
…rrectly null (facebook#48226) Summary: Adding logging to onHostPause to help diagnose cases when the activity is incorrectly null. Reviewed By: fkgozali Differential Revision: D67123351
mlord93
force-pushed
the
export-D67123351
branch
from
110e88d to
b2860ee
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67123351 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67123351 |
mlord93
force-pushed
the
export-D67123351
branch
from
b2860ee to
283c2bb
Compare
mlord93
pushed a commit
to mlord93/react-native
that referenced
this pull request
Dec 12, 2024
…rrectly null (facebook#48226) Summary: Adding logging to onHostPause to help diagnose cases when the activity is incorrectly null. Reviewed By: fkgozali Differential Revision: D67123351
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67123351 |
…rrectly null (facebook#48226) Summary: Adding logging to onHostPause to help diagnose cases when the activity is incorrectly null. Reviewed By: fkgozali Differential Revision: D67123351
mlord93
force-pushed
the
export-D67123351
branch
from
283c2bb to
65a3036
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67123351 |
Contributor
|
This pull request has been merged in c2fd35a. |
Collaborator
|
This pull request was successfully merged by Maddie Lord in c2fd35a When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding logging to onHostPause to help diagnose cases when the activity is incorrectly null.
Changelog: [Internal]
Differential Revision: D67123351