Allow creating empty surfaces without using AppRegistry initialization paths #48262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67199971 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 13, 2024
…n paths (facebook#48262) Summary: Changelog: [internal] At the moment, we can't start surfaces in Fabric without calling `AppRegistry.runApplication`. This is completely unnecessary in cases like Fantom, where the creation of the surface is done manually from JS and we render to it immediately after (so we don't need to call into JS again to run AppRegistry). Differential Revision: D67199971
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 13, 2024
…n paths (facebook#48262) Summary: Changelog: [internal] At the moment, we can't start surfaces in Fabric without calling `AppRegistry.runApplication`. This is completely unnecessary in cases like Fantom, where the creation of the surface is done manually from JS and we render to it immediately after (so we don't need to call into JS again to run AppRegistry). Reviewed By: javache Differential Revision: D67199971
rubennorte
force-pushed
the
export-D67199971
branch
from
0fc404e to
5103e02
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67199971 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 13, 2024
…tialization paths (facebook#48262) Summary: Changelog: [internal] At the moment, we can't start surfaces in Fabric without calling `AppRegistry.runApplication`. This is completely unnecessary in cases like Fantom, where the creation of the surface is done manually from JS and we render to it immediately after (so we don't need to call into JS again to run AppRegistry). Reviewed By: javache Differential Revision: D67199971
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 13, 2024
…tialization paths (facebook#48262) Summary: Changelog: [internal] At the moment, we can't start surfaces in Fabric without calling `AppRegistry.runApplication`. This is completely unnecessary in cases like Fantom, where the creation of the surface is done manually from JS and we render to it immediately after (so we don't need to call into JS again to run AppRegistry). Reviewed By: javache Differential Revision: D67199971
…n paths (facebook#48262) Summary: Changelog: [internal] At the moment, we can't start surfaces in Fabric without calling `AppRegistry.runApplication`. This is completely unnecessary in cases like Fantom, where the creation of the surface is done manually from JS and we render to it immediately after (so we don't need to call into JS again to run AppRegistry). Reviewed By: javache Differential Revision: D67199971
rubennorte
force-pushed
the
export-D67199971
branch
from
5103e02 to
7a96c95
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67199971 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 16, 2024
…tialization paths (facebook#48262) Summary: Changelog: [internal] At the moment, we can't start surfaces in Fabric without calling `AppRegistry.runApplication`. This is completely unnecessary in cases like Fantom, where the creation of the surface is done manually from JS and we render to it immediately after (so we don't need to call into JS again to run AppRegistry). Reviewed By: javache Differential Revision: D67199971
Contributor
|
This pull request has been merged in d1293f6. |
Collaborator
|
This pull request was successfully merged by @rubennorte in d1293f6 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
At the moment, we can't start surfaces in Fabric without calling
AppRegistry.runApplication.This is completely unnecessary in cases like Fantom, where the creation of the surface is done manually from JS and we render to it immediately after (so we don't need to call into JS again to run AppRegistry).
Differential Revision: D67199971