Rename the last remaining usage of parentShadowView.tag to parentTag #48267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67203413 |
…acebook#48267) Summary: `parentShadowView.tag` was renamed to `parentTag` in D66656411. This one callsite is hidden behind an `#ifdef`, so it didn't produce a compile error. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D67203413
dmytrorykun
force-pushed
the
export-D67203413
branch
from
68bc86f to
af96135
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67203413 |
Contributor
|
This pull request has been merged in eac4b32. |
Collaborator
|
This pull request was successfully merged by @dmytrorykun in eac4b32 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
parentShadowView.tagwas renamed toparentTagin D66656411. This one callsite is hidden behind an#ifdef, so it didn't produce a compile error.Changelog: [Internal]
Differential Revision: D67203413