Skip to content

Store backfaceVisibility as boolean #48268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javache wants to merge 1 commit into from
Closed

Store backfaceVisibility as boolean #48268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions ...react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public void shutdown() {
private boolean mNeedsOffscreenAlphaCompositing;
private @Nullable ViewGroupDrawingOrderHelper mDrawingOrderHelper;
private float mBackfaceOpacity;
private String mBackfaceVisibility;
private boolean mBackfaceVisible;
private @Nullable Set<Integer> mChildrenRemovedWhileTransitioning;

/**
Expand Down Expand Up @@ -172,7 +172,7 @@ private void initView() {
mNeedsOffscreenAlphaCompositing = false;
mDrawingOrderHelper = null;
mBackfaceOpacity = 1.f;
mBackfaceVisibility = "visible";
mBackfaceVisible = true;
mChildrenRemovedWhileTransitioning = null;
}

Expand Down Expand Up @@ -989,14 +989,12 @@ public void setOpacityIfPossible(float opacity) {
}

public void setBackfaceVisibility(String backfaceVisibility) {
mBackfaceVisibility = backfaceVisibility;
mBackfaceVisible = "visible".equals(backfaceVisibility);
setBackfaceVisibilityDependantOpacity();
}

public void setBackfaceVisibilityDependantOpacity() {
boolean isBackfaceVisible = mBackfaceVisibility.equals("visible");

if (isBackfaceVisible) {
if (mBackfaceVisible) {
setAlpha(mBackfaceOpacity);
return;
}
Expand Down
Loading