Refactor TraceEvent format #48269
Closed
Refactor TraceEvent format #48269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: # Changelog: [Internal] I've noticed that our definition of Trace Event is different from the one that is defined in Google's doc / V8 / Chrome. This has some flaws: * It creates fragmentation, like with custom track ids or with mocked process ids. * Current implementation is strict the relationship between `performance.mark()`, `performance.measure` APIs and Instant, Complete Trace Events. Basically only something recorded with `performance.mark` can be an instant trace event. This should unblock recording custom trace events inside `PerformanceTracer`, such as when tracing started and others. Same could be said about events related to CPU profiling from Hermes, which will be based on these APIs. This is the pre-requisite for next diff that will add emitting `TracingStartedInPage` event. With this event, the trace should look similar to the one recorded in the browser, and Timings / Main tracks no longer should be registered manually. Differential Revision: D67207107
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67207107 |
Contributor
|
This pull request has been merged in 03a1246. |
Collaborator
|
This pull request was successfully merged by @hoxyq in 03a1246 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
I've noticed that our definition of Trace Event is different from the one that is defined in Google's doc / V8 / Chrome. This has some flaws:
performance.mark(),performance.measureAPIs and Instant, Complete Trace Events. Basically only something recorded withperformance.markcan be an instant trace event.This should unblock recording custom trace events inside
PerformanceTracer, such as when tracing started and others. Same could be said about events related to CPU profiling from Hermes, which will be based on these APIs.This is the pre-requisite for next diff that will add emitting
TracingStartedInPageevent. With this event, the trace should look similar to the one recorded in the browser, and Timings / Main tracks no longer should be registered manually.Differential Revision: D67207107