Create TurboModule for test helpers #48283
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67111850 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Dec 16, 2024
Summary: Migrate from custom JSI integration to use TurboModule base-class. This doesn't use codegen right now for ease of migration, and to avoid needing to setup a js_library buck definition for react-native-fantom. We should also figure out what the right abstraction/division of responsibilities is going forward for TesterAppDelegate and FantomModule. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D67111850
javache
force-pushed
the
export-D67111850
branch
from
b43c7ae to
9dac312
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67111850 |
Summary: Migrate from custom JSI integration to use TurboModule base-class. This doesn't use codegen right now for ease of migration, and to avoid needing to setup a js_library buck definition for react-native-fantom. We should also figure out what the right abstraction/division of responsibilities is going forward for TesterAppDelegate and FantomModule. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D67111850
javache
force-pushed
the
export-D67111850
branch
from
9dac312 to
8e1fb91
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67111850 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Dec 16, 2024
Summary: Migrate from custom JSI integration to use TurboModule base-class. This doesn't use codegen right now for ease of migration, and to avoid needing to setup a js_library buck definition for react-native-fantom. We should also figure out what the right abstraction/division of responsibilities is going forward for TesterAppDelegate and FantomModule. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D67111850
Contributor
|
This pull request has been merged in ba8136e. |
Collaborator
|
This pull request was successfully merged by @javache in ba8136e When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Migrate from custom JSI integration to use TurboModule base-class.
This doesn't use codegen right now for ease of migration, and to avoid needing to setup a js_library buck definition for react-native-fantom. We should also figure out what the right abstraction/division of responsibilities is going forward for TesterAppDelegate and FantomModule.
Changelog: [Internal]
Reviewed By: rubennorte
Differential Revision: D67111850