Share ArrayTypeAnnotation between components and modules #48318
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67371894 |
elicwhite
force-pushed
the
export-D67371894
branch
from
aa66bb5 to
12a719a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67371894 |
elicwhite
force-pushed
the
export-D67371894
branch
from
12a719a to
f357ba5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67371894 |
elicwhite
force-pushed
the
export-D67371894
branch
from
f357ba5 to
3c9c0e3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67371894 |
elicwhite
added a commit
to elicwhite/react-native
that referenced
this pull request
Jan 2, 2025
…acebook#48318) Summary: These structures were the same, but the component side didn't use generics and just had duplicates. Making a base one to be shared. I need to follow up to this and constrain the types that components allow. Changelog: [Internal] Reviewed By: javache Differential Revision: D67371894
Contributor
|
This pull request has been merged in b691122. |
Collaborator
|
This pull request was successfully merged by @elicwhite in b691122 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These structures were the same, but the component side didn't use generics and just had duplicates. Making a base one to be shared.
I need to follow up to this and constrain the types that components allow.
Changelog: [Internal]
Differential Revision: D67371894