Always use AppRegistry globals in SurfaceRegistryBinding #48336
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67342498 |
javache
force-pushed
the
export-D67342498
branch
from
a7e9825 to
003c9a3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67342498 |
Summary: This API was never adopted or implemented on iOS, and is not compatible with bridgeless. Changelog: [Internal] Reviewed By: rshest Differential Revision: D67342500
javache
force-pushed
the
export-D67342498
branch
from
003c9a3 to
7233b66
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67342498 |
Contributor
|
This pull request has been merged in dbb75e3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
RN$AppRegistryandRN$stopSurfaceare always set on the init path, regardless of bridgeless or not, so we can remove the fallback path and cleanup this code.Changelog: [Internal]
Differential Revision: D67342498