Rename SurfaceRegistryBinding to AppRegistryBinding #48337
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67342499 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Dec 19, 2024
Summary: Pull Request resolved: facebook#48337 `SurfaceRegistryBinding` refers to a forked `SurfaceRegistry` we had for a while in bridgeless but which was merged back into `AppRegistry`. Align the native name as well to make it explicit that all this class does is call into `AppRegistry`. Changelog: [Internal] Differential Revision: D67342499
javache
force-pushed
the
export-D67342499
branch
from
087a1ca to
207483d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67342499 |
Differential Revision: D67342500
Differential Revision: D67342498
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67342499 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 7, 2025
Summary: Pull Request resolved: facebook#48337 `SurfaceRegistryBinding` refers to a forked `SurfaceRegistry` we had for a while in bridgeless but which was merged back into `AppRegistry`. Align the native name as well to make it explicit that all this class does is call into `AppRegistry`. Changelog: [Internal] Reviewed By: rshest Differential Revision: D67342499
javache
force-pushed
the
export-D67342499
branch
from
207483d to
f603349
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67342499 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 7, 2025
Summary: Pull Request resolved: facebook#48337 `SurfaceRegistryBinding` refers to a forked `SurfaceRegistry` we had for a while in bridgeless but which was merged back into `AppRegistry`. Align the native name as well to make it explicit that all this class does is call into `AppRegistry`. Changelog: [Internal] Reviewed By: rshest Differential Revision: D67342499
javache
force-pushed
the
export-D67342499
branch
from
f603349 to
b8b102a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67342499 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 7, 2025
Summary: Pull Request resolved: facebook#48337 `SurfaceRegistryBinding` refers to a forked `SurfaceRegistry` we had for a while in bridgeless but which was merged back into `AppRegistry`. Align the native name as well to make it explicit that all this class does is call into `AppRegistry`. Changelog: [Internal] Reviewed By: rshest Differential Revision: D67342499
javache
force-pushed
the
export-D67342499
branch
from
b8b102a to
3eb2b01
Compare
Summary: Pull Request resolved: facebook#48337 `SurfaceRegistryBinding` refers to a forked `SurfaceRegistry` we had for a while in bridgeless but which was merged back into `AppRegistry`. Align the native name as well to make it explicit that all this class does is call into `AppRegistry`. Changelog: [Internal] Reviewed By: rshest Differential Revision: D67342499
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67342499 |
javache
force-pushed
the
export-D67342499
branch
from
3eb2b01 to
3cf3ee2
Compare
Contributor
|
This pull request has been merged in afd77d5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
SurfaceRegistryBindingrefers to a forkedSurfaceRegistrywe had for a while in bridgeless but which was merged back intoAppRegistry. Align the native name as well to make it explicit that all this class does is call intoAppRegistry.Changelog: [Internal]
Differential Revision: D67342499