Drop dependency on native/fb #48568
Closed
Drop dependency on native/fb #48568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67796633 |
javache
force-pushed
the
export-D67796633
branch
from
7de5b99 to
e5b56f3
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 9, 2025
Summary: We only need this dependency for internal builds, as we only rely on fbjni, which is its own open-source project. This code was forked for open-source and not synced in anyway, which is a potential liability. Changelog: [Internal] Differential Revision: D67796633
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67796633 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 9, 2025
Summary: We only need this dependency for internal builds, as we only rely on fbjni, which is its own open-source project. This code was forked for open-source and not synced in anyway, which is a potential liability. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D67796633
javache
force-pushed
the
export-D67796633
branch
from
e5b56f3 to
cc28f28
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67796633 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 9, 2025
Summary: We only need this dependency for internal builds, as we only rely on fbjni, which is its own open-source project. This code was forked for open-source and not synced in anyway, which is a potential liability. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D67796633
javache
force-pushed
the
export-D67796633
branch
from
cc28f28 to
5774612
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67796633 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 9, 2025
Summary: We only need this dependency for internal builds, as we only rely on fbjni, which is its own open-source project. This code was forked for open-source and not synced in anyway, which is a potential liability. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D67796633
javache
force-pushed
the
export-D67796633
branch
from
5774612 to
f366d79
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67796633 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 9, 2025
Summary: We only need this dependency for internal builds, as we only rely on fbjni, which is its own open-source project. This code was forked for open-source and not synced in anyway, which is a potential liability. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D67796633
javache
force-pushed
the
export-D67796633
branch
from
f366d79 to
24b3b48
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67796633 |
Summary: Follow-up: default log level in prod: https://www.internalfb.com/diff/D37541647 Differential Revision: D67461225
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 10, 2025
Summary: Pull Request resolved: facebook#48568 We only need this dependency for internal builds, as we only rely on fbjni, which is its own open-source project. This code was forked for open-source and not synced in anyway, which is a potential liability. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D67796633
javache
force-pushed
the
export-D67796633
branch
from
24b3b48 to
cd3cb56
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67796633 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 10, 2025
Summary: Pull Request resolved: facebook#48568 We only need this dependency for internal builds, as we only rely on fbjni, which is its own open-source project. This code was forked for open-source and not synced in anyway, which is a potential liability. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D67796633
javache
force-pushed
the
export-D67796633
branch
from
cd3cb56 to
aa8ce66
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67796633 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 10, 2025
Summary: Pull Request resolved: facebook#48568 We only need this dependency for internal builds, as we only rely on fbjni, which is its own open-source project. This code was forked for open-source and not synced in anyway, which is a potential liability. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D67796633
javache
force-pushed
the
export-D67796633
branch
from
aa8ce66 to
4454852
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67796633 |
Summary: Pull Request resolved: facebook#48568 We only need this dependency for internal builds, as we only rely on fbjni, which is its own open-source project. This code was forked for open-source and not synced in anyway, which is a potential liability. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D67796633
javache
force-pushed
the
export-D67796633
branch
from
4454852 to
60e77e2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67796633 |
Contributor
|
This pull request has been merged in f6f7de6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We only need this dependency for internal builds, as we only rely on fbjni, which is its own open-source project.
This code was forked for open-source and not synced in anyway, which is a potential liability.
Changelog: [Internal]
Differential Revision: D67796633